From: shawn.guo@freescale.com (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: imx6: add pci config space as platform resource
Date: Fri, 8 Aug 2014 16:51:19 +0800 [thread overview]
Message-ID: <20140808085118.GR2167@dragon> (raw)
In-Reply-To: <1407486964.5167.4.camel@weser.hi.pengutronix.de>
On Fri, Aug 08, 2014 at 10:36:04AM +0200, Lucas Stach wrote:
> Am Donnerstag, den 07.08.2014, 15:12 -0300 schrieb Fabio Estevam:
> > On Thu, Aug 7, 2014 at 2:39 PM, Lucas Stach <l.stach@pengutronix.de> wrote:
> > > Fixes "imx6q-pcie 1ffc000.pcie: missing *config* reg space"
> > > error exposed by new versions of the designware pcie driver.
> > >
> > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > > ---
> > > v2: also fix documentation example
> > > ---
> > > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 4 +++-
> > > arch/arm/boot/dts/imx6qdl.dtsi | 4 +++-
> > > 2 files changed, 6 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> > > index 9455fd0ec830..6fbba53a309b 100644
> > > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> > > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> > > @@ -17,7 +17,9 @@ Example:
> > >
> > > pcie at 0x01000000 {
> > > compatible = "fsl,imx6q-pcie", "snps,dw-pcie";
> > > - reg = <0x01ffc000 0x4000>;
> > > + reg = <0x01ffc000 0x04000>,
> > > + <0x01f00000 0x80000>;
> > > + reg-names = "dbi", "config";
> >
> > It would be nice to update the 'reg' description and add the
> > 'reg-names' entry in the 'Required properties' section.
> >
> > Currently we have the following description:
> >
> > "reg: base addresse (---> typo here) and length of the pcie
> > controller" ,which does not match the provided example after your
> > patch.
> >
> I'm a bit on the fence here. Yes, it's a bit inconsistent with the
> example, but it's actually the same approach chosen for other properties
> like clocks. Base properties are inherited from designware-pcie.txt and
> only additional things are documented in fsl,imx6q-pcie.txt.
>
> I'm leaning toward not breaking the existing practice.
+1
Will apply it as a fix once v3.17-rc1 is out. Remind me if I forget.
Shawn
next prev parent reply other threads:[~2014-08-08 8:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 17:39 [PATCH v2] ARM: imx6: add pci config space as platform resource Lucas Stach
2014-08-07 18:12 ` Fabio Estevam
2014-08-08 8:36 ` Lucas Stach
2014-08-08 8:51 ` Shawn Guo [this message]
2014-09-01 14:41 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140808085118.GR2167@dragon \
--to=shawn.guo@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.