From: Stephen Hemminger <stephen@networkplumber.org>
To: Zoltan Kiss <zoltan.kiss@citrix.com>
Cc: David Vrabel <david.vrabel@citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <Ian.Campbell@citrix.com>, <netdev@vger.kernel.org>,
<xen-devel@lists.xenproject.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH] xen-netback: Turn off the carrier if the guest is not able to receive
Date: Fri, 8 Aug 2014 09:33:56 -0700 [thread overview]
Message-ID: <20140808093356.04d7228b@haswell.linuxnetplumber.net> (raw)
In-Reply-To: <53DFA30E.2000301@citrix.com>
This idea of bouncing carrier is wrong. If guest is flow blocked you don't
want to toggle carrier. That will cause problems because applications that are
looking for carrier transistions like routing daemons will be notified.
If running a routing daemon this will also lead to link flapping which
is very bad and cause lots of other work for peer routing daemons.
Carrier is not a suitable flow control mechanism.
next prev parent reply other threads:[~2014-08-08 16:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 19:50 [PATCH] xen-netback: Using a new state bit instead of carrier Zoltan Kiss
2014-07-30 19:50 ` [PATCH] xen-netback: Turn off the carrier if the guest is not able to receive Zoltan Kiss
2014-08-01 4:53 ` David Miller
2014-08-01 4:53 ` David Miller
2014-08-01 10:52 ` Wei Liu
2014-08-04 15:04 ` Zoltan Kiss
2014-08-04 15:04 ` Zoltan Kiss
2014-08-01 10:52 ` Wei Liu
2014-08-04 13:35 ` [Xen-devel] " David Vrabel
2014-08-04 15:13 ` Zoltan Kiss
2014-08-04 15:13 ` [Xen-devel] " Zoltan Kiss
2014-08-08 16:33 ` Stephen Hemminger
2014-08-08 16:33 ` Stephen Hemminger [this message]
2014-08-11 12:31 ` Zoltan Kiss
2014-08-11 12:31 ` [Xen-devel] " Zoltan Kiss
2014-08-11 12:37 ` David Vrabel
2014-08-11 12:37 ` [Xen-devel] " David Vrabel
2014-08-04 13:35 ` David Vrabel
2014-07-30 19:50 ` Zoltan Kiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140808093356.04d7228b@haswell.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=Ian.Campbell@citrix.com \
--cc=david.vrabel@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
--cc=zoltan.kiss@citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.