All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Miguel Oliveira <cmroliv@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Larry.Finger@lwfinger.net
Subject: Re: [PATCH] staging: rtl8188eu: HalPhyRf_8188e: Fix static symbol sparse warning
Date: Sat, 9 Aug 2014 21:25:49 -0700	[thread overview]
Message-ID: <20140810042549.GA20106@kroah.com> (raw)
In-Reply-To: <1407269028-10673-1-git-send-email-cmroliv@gmail.com>

On Tue, Aug 05, 2014 at 09:03:48PM +0100, Miguel Oliveira wrote:
> Fix sparse warning:
> drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c:25:4: warning: symbol 'ODM_GetRightChnlPlaceforIQK' was not declared. Should it be static?
> by making it static since it's only used once.
> 
> Signed-off-by: Miguel Oliveira <cmroliv@gmail.com>
> ---
>  drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c b/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c
> index 7fa744b..d2bcc16 100644
> --- a/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c
> +++ b/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c
> @@ -22,7 +22,7 @@
>  #define		ODM_TXPWRTRACK_MAX_IDX_88E		6
>  
>  
> -u8 ODM_GetRightChnlPlaceforIQK(u8 chnl)
> +static u8 ODM_GetRightChnlPlaceforIQK(u8 chnl)
>  {
>  	u8	channel_all[ODM_TARGET_CHNL_NUM_2G_5G] = {
>  		1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14,

Someone else made this change already, always work against the
linux-next tree :(

thanks,

greg k-h

      reply	other threads:[~2014-08-10 12:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-05 20:03 [PATCH] staging: rtl8188eu: HalPhyRf_8188e: Fix static symbol sparse warning Miguel Oliveira
2014-08-10  4:25 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140810042549.GA20106@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=cmroliv@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.