All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	Adrian Remonda <adrianremonda@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Larry.Finger@lwfinger.net
Subject: Re: [PATCHv2 2/2] Staging: rtl8188eu: Removed unnecessarry code.
Date: Sat, 9 Aug 2014 21:27:30 -0700	[thread overview]
Message-ID: <20140810042730.GA25108@kroah.com> (raw)
In-Reply-To: <20140808090538.GH4856@mwanda>

On Fri, Aug 08, 2014 at 12:05:38PM +0300, Dan Carpenter wrote:
> On Thu, Aug 07, 2014 at 11:37:51PM +0200, Adrian Remonda wrote:
> > This patch clear some code that was not doing any help.
> > Pointed out by Larry.Finger
> > 
> 
> The patch is fine but the changelog doesn't inpsire confidence.  It
> should say:
> 
> This patch removes some unneeded code.
> 1) kzalloc() allocates 4 extra bytes so that we can align the return
>    value.  But actually the return value is already aligned so we can
>    remove the + 4 and the call to N_BYTE_ALIGMENT().
> 2) The memset() isn't needed because kzalloc() zeroes the allocation.
> 
> Suggested-by: Larry Finger <Larry.Finger@lwfinger.net>

Adrian, can you please fix this up and resend the series based on Dan's
comments?

thanks,

greg k-h

      reply	other threads:[~2014-08-10 12:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-07 21:37 [PATCHv2 1/2] Staging: rtl8188eu: Lines over 80 characters fixed Adrian Remonda
2014-08-07 21:37 ` [PATCHv2 2/2] Staging: rtl8188eu: Removed unnecessarry code Adrian Remonda
2014-08-08  9:05   ` Dan Carpenter
2014-08-10  4:27     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140810042730.GA25108@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=adrianremonda@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.