All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Christoph Jaeger <email@christophjaeger.info>
Cc: shigekatsu.tateno@atmel.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/10] staging: ozwpan: Fix typo in typedef
Date: Sat, 9 Aug 2014 21:42:04 -0700	[thread overview]
Message-ID: <20140810044204.GA27046@kroah.com> (raw)
In-Reply-To: <1407156896-3246-3-git-send-email-email@christophjaeger.info>

On Mon, Aug 04, 2014 at 02:54:48PM +0200, Christoph Jaeger wrote:
> Signed-off-by: Christoph Jaeger <email@christophjaeger.info>
> ---
>  drivers/staging/ozwpan/ozproto.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/ozwpan/ozproto.h b/drivers/staging/ozwpan/ozproto.h
> index cb38e02..378b737 100644
> --- a/drivers/staging/ozwpan/ozproto.h
> +++ b/drivers/staging/ozwpan/ozproto.h
> @@ -34,7 +34,7 @@ typedef void (*oz_app_term_fn_t)(void);
>  typedef int (*oz_app_start_fn_t)(struct oz_pd *pd, int resume);
>  typedef void (*oz_app_stop_fn_t)(struct oz_pd *pd, int pause);
>  typedef void (*oz_app_rx_fn_t)(struct oz_pd *pd, struct oz_elt *elt);
> -typedef int (*oz_app_hearbeat_fn_t)(struct oz_pd *pd);
> +typedef int (*oz_app_heartbeat_fn_t)(struct oz_pd *pd);
>  typedef void (*oz_app_farewell_fn_t)(struct oz_pd *pd, u8 ep_num,
>  			u8 *data, u8 len);
>  
> @@ -44,7 +44,7 @@ struct oz_app_if {
>  	oz_app_start_fn_t	start;
>  	oz_app_stop_fn_t	stop;
>  	oz_app_rx_fn_t		rx;
> -	oz_app_hearbeat_fn_t	heartbeat;
> +	oz_app_heartbeat_fn_t	heartbeat;
>  	oz_app_farewell_fn_t	farewell;
>  	int			app_id;
>  };

As these typedefs are only used in this one structure, there's no real
need for them, you can remove them in a later patch if you want.

thanks,

greg k-h

  reply	other threads:[~2014-08-10 12:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-04 12:54 [PATCH 00/10] staging: Clean up ozwpan driver Christoph Jaeger
2014-08-04 12:54 ` [PATCH 01/10] staging: ozwpan: Add module parameter description Christoph Jaeger
2014-08-04 12:54 ` [PATCH 02/10] staging: ozwpan: Fix typo in typedef Christoph Jaeger
2014-08-10  4:42   ` Greg KH [this message]
2014-08-04 12:54 ` [PATCH 03/10] staging: ozwpan: Remove unused OZ_MAX_TIMER_POOL_SIZE Christoph Jaeger
2014-08-04 12:54 ` [PATCH 04/10] staging: ozwpan: Remove redundant initialization Christoph Jaeger
2014-08-04 12:54 ` [PATCH 05/10] staging: ozwpan: Remove dead code Christoph Jaeger
2014-08-04 12:54 ` [PATCH 06/10] staging: ozwpan: Simplify app interface Christoph Jaeger
2014-08-05 11:13   ` Dan Carpenter
2014-08-04 12:54 ` [PATCH 07/10] staging: ozwpan: Use slab cache for oz_urb_link allocation Christoph Jaeger
2014-08-05 11:18   ` Dan Carpenter
2014-08-08  5:59   ` [PATCH 07/10 v2] " Christoph Jaeger
2014-08-04 12:54 ` [PATCH 08/10] staging: ozwpan: Use slab cache for oz_elt_info allocation Christoph Jaeger
2014-08-08  6:00   ` [PATCH 08/10 v2] " Christoph Jaeger
2014-08-04 12:54 ` [PATCH 09/10] staging: ozwpan: Use slab cache for oz_tx_frame allocation Christoph Jaeger
2014-08-08  6:01   ` [PATCH 09/10 v2] " Christoph Jaeger
2014-08-04 12:54 ` [PATCH 10/10] staging: ozwpan: Use list helpers Christoph Jaeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140810044204.GA27046@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=email@christophjaeger.info \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shigekatsu.tateno@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.