From: Theodore Ts'o <tytso@mit.edu>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 5/6] libext2fs/e2fsck: provide routines to read-ahead metadata
Date: Mon, 11 Aug 2014 02:24:15 -0400 [thread overview]
Message-ID: <20140811062415.GG15431@thunk.org> (raw)
In-Reply-To: <20140811052151.GA2808@birch.djwong.org>
On Sun, Aug 10, 2014 at 10:21:51PM -0700, Darrick J. Wong wrote:
>
> It turns out that each of the calls to ext2fs_resize_mem in the
> ext2fs_add_dir_block2() function is costing us ~2ms for each call to this
> function. I'll add a new ext2fs_init_dblist() APi that lets us specify the
> initial size of the list. This seems to reduce the fsck runtime by a few more
> seconds.
I suspect dblist is the wrong abstraction to use here. Since the
blocks we want to read ahead are generally going to be contiguous, why
not use a rbtree bitmap, setting the blocks that should be subject to
readahead, and then use the find_first_set() function to iterate over
the bitmap? Or if you want to be even more efficient, create an
interator function which takes a bitmap and returns blocks that are
set in the bitmap, one by one.
- Ted
next prev parent reply other threads:[~2014-08-11 6:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-09 4:26 [PATCH 0/6] e2fsprogs Summer 2014 patchbomb, part 5 Darrick J. Wong
2014-08-09 4:26 ` [PATCH 1/6] libext2fs: create inlinedata symlinks Darrick J. Wong
2014-08-24 16:15 ` Theodore Ts'o
2014-08-09 4:26 ` [PATCH 2/6] misc: fix gcc warnings Darrick J. Wong
2014-08-24 16:24 ` Theodore Ts'o
2014-08-09 4:26 ` [PATCH 3/6] mke2fs: set block_validity as a default mount option Darrick J. Wong
2014-08-24 22:47 ` Theodore Ts'o
2014-08-25 15:52 ` Darrick J. Wong
2014-08-25 16:36 ` [PATCH] ext4: enable block_validity by default Darrick J. Wong
2014-09-02 2:02 ` Theodore Ts'o
2014-08-09 4:26 ` [PATCH 4/6] ext2fs: add readahead method to improve scanning Darrick J. Wong
2014-08-09 4:26 ` [PATCH 5/6] libext2fs/e2fsck: provide routines to read-ahead metadata Darrick J. Wong
2014-08-11 5:21 ` Darrick J. Wong
2014-08-11 6:24 ` Theodore Ts'o [this message]
2014-08-11 6:31 ` Darrick J. Wong
2014-08-11 14:34 ` Theodore Ts'o
2014-08-11 18:05 ` Darrick J. Wong
2014-08-11 18:32 ` Theodore Ts'o
2014-08-11 18:55 ` Darrick J. Wong
2014-08-11 20:10 ` Theodore Ts'o
2014-08-11 20:50 ` Darrick J. Wong
2014-08-09 4:26 ` [PATCH 6/6] e2fsck: read-ahead metadata during passes 1, 2, and 4 Darrick J. Wong
2014-08-09 5:53 ` [PATCH 0/6] e2fsprogs Summer 2014 patchbomb, part 5 Theodore Ts'o
2014-08-09 5:59 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140811062415.GG15431@thunk.org \
--to=tytso@mit.edu \
--cc=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.