Re: [PATCH] recipes-devtools: Add OVMF recipe

[Matt Fleming <matt@console-pimps.org>]

On Tue, 12 Aug, at 05:51:38PM, Martin Jansa wrote:
> 
> I don't think we have iasl in oe-core.
 
Oops, my bad. I thought I'd checked that but turns out I was looking in
the wrong tree.

I'll include the iasl recipe with the next submission.

> Also the styleguide says you should use space around = (SRCREV, DEPENDS,
> COMPATIBLE_HOST, BUILD_OPTIMIZATION, GCC_VER)
 
Thanks, I'll update the patch.

> > +# OVMF has trouble building with the default optimization of -O2.
> > +BUILD_OPTIMIZATION="-pipe"
> > +
> > +# OVMF supports IA only, although it could conceivably support ARM someday.
> > +COMPATIBLE_HOST='(i.86|x86_64).*'
> > +
> > +do_patch_append() {
> > +    bb.build.exec_func('do_fix_iasl', d)
> > +    bb.build.exec_func('do_fix_toolchain', d)
> 
> Why don't you fix them in do_configure_prepend?

What's the tradeoff?

Though I realise that we're not actually *patching* anything and so
do_configure_prepend() probably does make more semantic sense.

Ah, after a bit of grepping I see that it's a pretty common pattern. OK,
sure, I'll update this.

Thanks for the review.

-- 
Matt Fleming, Intel Open Source Technology Center