From: Fengguang Wu <fengguang.wu@intel.com>
To: x86@kernel.org
Cc: Ingo Molnar <mingo@redhat.com>, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86: fix messed up page fault BUG messages
Date: Wed, 13 Aug 2014 19:27:24 +0800 [thread overview]
Message-ID: <20140813112724.GA6338@localhost> (raw)
The 0day boot test robot hits messed up BUG lines like
[ 25.732010] BUG: unable to handle kernel paging requestrun: /lkp/wfg/sr at 000000000000d908
[ 24.986598] BUG: unable to handle kernel run: /lkp/wfg/srpaging request at 000000000000d908
[ 24.914406] BUG: unable to handle kernel run: /lkp/wfg/srearly console in decompress_kernel
Which makes the generated bug ID not stable and hence not bisectable.
Fix it by printing the BUG message in one shot.
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
arch/x86/mm/fault.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c
index 3664279..f3e0e0a 100644
--- a/arch/x86/mm/fault.c
+++ b/arch/x86/mm/fault.c
@@ -599,13 +599,13 @@ show_fault_oops(struct pt_regs *regs, unsigned long error_code,
printk(nx_warning, from_kuid(&init_user_ns, current_uid()));
}
- printk(KERN_ALERT "BUG: unable to handle kernel ");
if (address < PAGE_SIZE)
- printk(KERN_CONT "NULL pointer dereference");
+ printk(KERN_ALERT "BUG: unable to handle kernel NULL pointer dereference at %p\n",
+ (void *) address);
else
- printk(KERN_CONT "paging request");
+ printk(KERN_ALERT "BUG: unable to handle kernel NULL pointer paging request at %p\n",
+ (void *) address);
- printk(KERN_CONT " at %p\n", (void *) address);
printk(KERN_ALERT "IP:");
printk_address(regs->ip);
--
2.1.0.rc1
next reply other threads:[~2014-08-13 11:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 11:27 Fengguang Wu [this message]
2014-08-13 23:16 ` [PATCH] x86: fix messed up page fault BUG messages David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140813112724.GA6338@localhost \
--to=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.