From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: re: drm/nv50-/disp: audit and version DAC_LOAD method Date: Wed, 13 Aug 2014 14:29:16 +0300 Message-ID: <20140813112916.GA24203@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) by gabe.freedesktop.org (Postfix) with ESMTP id E58066E02D for ; Wed, 13 Aug 2014 04:29:35 -0700 (PDT) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: bskeggs@redhat.com Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org Hello Ben Skeggs, The patch c4abd3178e11: "drm/nv50-/disp: audit and version DAC_LOAD method" from Aug 10, 2014, leads to the following static checker warning: drivers/gpu/drm/nouveau/core/engine/disp/dacnv50.c:78 nv50_dac_sense() warn: 0xfff00000 is larger than 16 bits drivers/gpu/drm/nouveau/core/engine/disp/dacnv50.c 65 nv50_dac_sense(NV50_DISP_MTHD_V1) 66 { 67 union { 68 struct nv50_disp_dac_load_v0 v0; 69 } *args = data; 70 const u32 doff = outp->or * 0x800; 71 u32 loadval; 72 int ret; 73 74 nv_ioctl(object, "disp dac load size %d\n", size); 75 if (nvif_unpack(args->v0, 0, 0, false)) { 76 nv_ioctl(object, "disp dac load vers %d data %08x\n", 77 args->v0.version, args->v0.data); 78 if (args->v0.data & 0xfff00000) ^^^^^^^^^^^^^^^^^^^^^^^^^^ This condition can't be true. It's not clear what was intended. 79 return -EINVAL; 80 loadval = args->v0.data; 81 } else 82 return ret; regards, dan carpenter