From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/2] drm/i915: Move i915_gem_chipset_flush to where it belongs Date: Wed, 13 Aug 2014 14:23:14 +0200 Message-ID: <20140813122314.GY10500@phenom.ffwll.local> References: <1407927115-16526-1-git-send-email-chris@chris-wilson.co.uk> <1407927115-16526-2-git-send-email-chris@chris-wilson.co.uk> <20140813113231.GS10500@phenom.ffwll.local> <20140813114511.GC10052@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by gabe.freedesktop.org (Postfix) with ESMTP id A1D946E058 for ; Wed, 13 Aug 2014 05:23:02 -0700 (PDT) Received: by mail-wi0-f181.google.com with SMTP id bs8so700107wib.2 for ; Wed, 13 Aug 2014 05:23:01 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140813114511.GC10052@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Daniel Vetter , intel-gfx@lists.freedesktop.org, Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Wed, Aug 13, 2014 at 12:45:11PM +0100, Chris Wilson wrote: > On Wed, Aug 13, 2014 at 01:32:31PM +0200, Daniel Vetter wrote: > > On Wed, Aug 13, 2014 at 11:51:55AM +0100, Chris Wilson wrote: > > > From: Daniel Vetter > > > > > > That's right, back to where it was! > > > > > > This effectively reverts > > > > Hm, why? > > Becuase it doesn't belong in i915_gem_gtt.c since the flush is not about > flushing the GGTT and it is not used in i915_gem_gtt.c Indeed, makes sense. Dropped my original patch from dinq. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch