From mboxrd@z Thu Jan 1 00:00:00 1970 From: Theodore Ts'o Subject: Re: [PATCH v5 0/5] random,x86,kvm: Rework arch RNG seeds and get some from kvm Date: Wed, 13 Aug 2014 14:22:19 -0400 Message-ID: <20140813182219.GE6437@thunk.org> References: <20140812191723.GI12871@thunk.org> <53EB1859.6030800@zytor.com> <20140813143209.GD6437@thunk.org> <53EBA435.3020207@zytor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andy Lutomirski , kvm list , "linux-kernel@vger.kernel.org" , Kees Cook , X86 ML , Daniel Borkmann , Srivatsa Vaddagiri , Raghavendra K T , Gleb Natapov , Paolo Bonzini , Bandan Das , Andrew Honig To: "H. Peter Anvin" Return-path: Content-Disposition: inline In-Reply-To: <53EBA435.3020207@zytor.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Wed, Aug 13, 2014 at 10:45:25AM -0700, H. Peter Anvin wrote: > On 08/13/2014 09:13 AM, Andy Lutomirski wrote: > > > > Sounds good to me. > > > > FWIW, I'd like to see a second use added in random.c: I think that we > > should do this, or even all of init_std_data, on resume from suspend > > and especially on resume from hibernate / kexec. > > > > Yes, we should. We also need to make it possible to do this after > cloning a VM. Agreed. Can you send a patch? I can carry the commits to add arch_random_init() the generic version, and the patch to call it after suspend/resume. I'll do this at the very head of the random tree, and make sure it gets pushed to Linus early during the next merge window. Does that sound like a plan? Or does someone want to suggest something different? I'm flexible... - Ted