From: "Theodore Ts'o" <tytso@mit.edu>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, hpa@linux.intel.com,
Amos Kong <akong@redhat.com>,
ricardo.neri-calderon@linux.intel.com,
Amit Shah <amit.shah@redhat.com>
Subject: Re: [PATCH] virtio: rng: add derating factor for use by hwrng core
Date: Wed, 13 Aug 2014 18:44:40 -0400 [thread overview]
Message-ID: <20140813224440.GA10808@thunk.org> (raw)
In-Reply-To: <87zjf88awc.fsf@rustcorp.com.au>
On Thu, Aug 14, 2014 at 04:39:07AM +0930, Rusty Russell wrote:
> The khwrngd thread is started when a hwrng device of sufficient
> quality is registered. The virtio-rng device is backed by the
> hypervisor, and we trust the hypervisor to provide real entropy.
>
> A malicious hypervisor is a scenario that's irrelevant -- such a setup
> is bound to cause all sorts of badness, and a compromised hwrng is not
> the biggest threat.
s/malicious/malicious or badly implemented/
s/is not the biggest threat/is the least of the user's worries/
> Given this, we are certain the quality of randomness we receive is
> perfectly trustworthy. Hence, we use 100% for the factor, indicating
> maximum confidence in the source.
s/we are certain/we might as well assume that/
I won't insist on the wording changes, but I think it's a better way
of phrasing things.
Cheers,
- Ted
next prev parent reply other threads:[~2014-08-13 22:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 19:09 [PATCH] virtio: rng: add derating factor for use by hwrng core Rusty Russell
2014-08-13 20:49 ` H. Peter Anvin
2014-08-13 22:44 ` Theodore Ts'o [this message]
2014-08-14 18:51 ` Amos Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140813224440.GA10808@thunk.org \
--to=tytso@mit.edu \
--cc=akong@redhat.com \
--cc=amit.shah@redhat.com \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.