From: Minchan Kim <minchan@kernel.org>
To: Chao Yu <chao2.yu@samsung.com>
Cc: ngupta@vflare.org, linux-kernel@vger.kernel.org,
"'Jerome Marchand'" <jmarchan@redhat.com>,
"'Sergey Senozhatsky'" <sergey.senozhatsky@gmail.com>,
"'Andrew Morton'" <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] zram: fix incorrectly stat with failed_reads
Date: Thu, 14 Aug 2014 09:26:54 +0900 [thread overview]
Message-ID: <20140814002654.GH9227@bbox> (raw)
In-Reply-To: <009001cfb69a$a8470840$f8d518c0$@samsung.com>
On Wed, Aug 13, 2014 at 10:01:45AM +0800, Chao Yu wrote:
> Since we allocate a temporary buffer in zram_bvec_read to handle partial page
> operations in this commit 924bd88d703e53d30f393fac6117f8f1bc79aab6 (Staging:
> zram: allow partial page operations), our ->failed_reads value may be incorrect
> as we do not increase its value when failed to allocate the temporary buffer.
>
> Let's fix this issue and correct the annotation of failed_reads.
>
> v2: clean codes of failed_{reads,writes} stat pointed out by Minchan Kim, and
> this cleanup also fix incorrectly stat when fail in zram_decompress_page.
>
> Signed-off-by: Chao Yu <chao2.yu@samsung.com>
Acked-by: Minchan Kim <minchan@kernel.org>
Thanks!
--
Kind regards,
Minchan Kim
prev parent reply other threads:[~2014-08-14 0:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 2:01 [PATCH v2] zram: fix incorrectly stat with failed_reads Chao Yu
2014-08-13 8:31 ` Jerome Marchand
2014-08-13 11:32 ` Sergey Senozhatsky
2014-08-13 14:43 ` Sergey Senozhatsky
2014-08-13 14:49 ` Sergey Senozhatsky
2014-08-13 23:02 ` Minchan Kim
2014-08-14 12:54 ` Sergey Senozhatsky
2014-08-14 0:26 ` Minchan Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140814002654.GH9227@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=chao2.yu@samsung.com \
--cc=jmarchan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ngupta@vflare.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.