From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-la0-f46.google.com (mail-la0-f46.google.com [209.85.215.46]) by mail.openembedded.org (Postfix) with ESMTP id 5FC0160144 for ; Thu, 14 Aug 2014 08:51:24 +0000 (UTC) Received: by mail-la0-f46.google.com with SMTP id b8so735498lan.19 for ; Thu, 14 Aug 2014 01:51:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=8MrrCKgrEHngOj4oDVAd0dM7MVkrnivEYhFlPiBP5KE=; b=QEnxiB7tJXn0Z6/rIYSCuwfaYE78KmWGEIBlo34/YDp+19BuO+tbYntkKUGoZkfOL9 ES2GgUTNLBr9Cmotdo2cxEInOmwohp4MajnUWyZhGWyRacNQ7M+XvgyPxNZjZ7WR8+v4 gIefBPji++QyL5GCqExYN1WiDYijNtClTelvRLKu2Lk078PZSVZxXwyeF6/po+vp2WN7 71ZflcWSF8zpTDgQ+4MsxE9WeUegxX1hCNRxnzF2fWDdp/uvGnEONAQYC/lJHiBJw+h4 uTzJibJoja3XC+cep/G4oWZV+L9XftAhy7dkKF2YuQ195xrIucq/ERH3hRa/UiJxOtrB RssQ== X-Received: by 10.112.169.35 with SMTP id ab3mr3205806lbc.41.1408006284522; Thu, 14 Aug 2014 01:51:24 -0700 (PDT) Received: from localhost (ip-89-176-104-3.net.upcbroadband.cz. [89.176.104.3]) by mx.google.com with ESMTPSA id d7sm2728997lah.46.2014.08.14.01.51.23 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Aug 2014 01:51:23 -0700 (PDT) From: Martin Jansa X-Google-Original-From: Martin Jansa Date: Thu, 14 Aug 2014 10:52:01 +0200 To: openembedded-devel@lists.openembedded.org Message-ID: <20140814085201.GF14848@jama> References: <1408002596-9778-1-git-send-email-kai.kang@windriver.com> <53EC6CFA.9050406@windriver.com> <20140814083809.GD14848@jama> <53EC766B.8090402@windriver.com> MIME-Version: 1.0 In-Reply-To: <53EC766B.8090402@windriver.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [meta-perl][PATCH 1/6] libdigest-sha1-perl: add recipe X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Aug 2014 08:51:26 -0000 X-Groupsio-MsgNum: 51678 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IaumfLDne4EPF0pV" Content-Disposition: inline --IaumfLDne4EPF0pV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 14, 2014 at 04:42:19PM +0800, Kang Kai wrote: > On 2014?08?14? 16:38, Martin Jansa wrote: > > On Thu, Aug 14, 2014 at 04:02:02PM +0800, Kang Kai wrote: > >> This series of commits is for layer *meta-perl*, and I add it in cover > >> letter created by 'git send-email --compose', but it seems doesn't wor= k. > > Please update indentation in them, you're using mix of tabs and spaces > > -> use 4 spaces everywhere. >=20 > Even in the shell function, such as >=20 > +do_install_ptest () { > + cp -r ${B}/t ${D}${PTEST_PATH} > +} >=20 >=20 > I just thought it should be indented with tab. Yes, tabs in shell tasks are used only by oe-core, meta-oe, meta-smartphone= , meta-qt5, meta-webos, .. are using consistent styleguide with 4 spaces everywhere. > If so, I'll update them and send V2. >=20 > Thanks, > Kai >=20 > > > >> On 2014?08?14? 15:49, Kai Kang wrote: > >> > >> > >>> Add recipe for libdigest-sha1-perl and enable create -ptest sub-packa= ge. > >>> > >>> Signed-off-by: Kai Kang > >>> --- > >>> meta-perl/recipes-perl/libdigest/files/run-ptest | 16 ++++++++++= ++++ > >>> .../libdigest/libdigest-sha1-perl_2.13.bb | 25 ++++++++++= ++++++++++++ > >>> 2 files changed, 41 insertions(+) > >>> create mode 100644 meta-perl/recipes-perl/libdigest/files/run-ptest > >>> create mode 100644 meta-perl/recipes-perl/libdigest/libdigest-sha1= -perl_2.13.bb > >>> > >>> diff --git a/meta-perl/recipes-perl/libdigest/files/run-ptest b/meta-= perl/recipes-perl/libdigest/files/run-ptest > >>> new file mode 100644 > >>> index 0000000..1c008b5 > >>> --- /dev/null > >>> +++ b/meta-perl/recipes-perl/libdigest/files/run-ptest > >>> @@ -0,0 +1,16 @@ > >>> +#!/bin/sh > >>> + > >>> +for case in `find t -type f -name '*.t'`; do > >>> + perl $case >$case.output 2>&1 > >>> + ret=3D$? > >>> + cat $case.output > >>> + if [ $ret -ne 0 ]; then > >>> + echo "FAIL: ${case%.t}" > >>> + elif grep -i 'SKIP' $case.output; then > >>> + echo "SKIP: ${case%.t}" > >>> + else > >>> + echo "PASS: ${case%.t}" > >>> + fi > >>> + > >>> + rm -f $case.output > >>> +done > >>> diff --git a/meta-perl/recipes-perl/libdigest/libdigest-sha1-perl_2.1= 3.bb b/meta-perl/recipes-perl/libdigest/libdigest-sha1-perl_2.13.bb > >>> new file mode 100644 > >>> index 0000000..42d5875 > >>> --- /dev/null > >>> +++ b/meta-perl/recipes-perl/libdigest/libdigest-sha1-perl_2.13.bb > >>> @@ -0,0 +1,25 @@ > >>> +SUMMARY =3D "Perl interface to the SHA-1 algorithm " > >>> +DESCRIPTION =3D "Digest::SHA1 - Perl interface to the SHA-1 algorith= m" > >>> +HOMEPAGE =3D "http://search.cpan.org/~gaas/Digest-SHA1-2.13/" > >>> +SECTION =3D "libs" > >>> + > >>> +LICENSE =3D "Artistic-1.0|GPLv1+" > >>> +LIC_FILES_CHKSUM =3D "file://README;beginline=3D10;endline=3D14;md5= =3Dff5867ebb4bc1103a7a416aef2fce00a" > >>> + > >>> +SRC_URI =3D "http://search.cpan.org/CPAN/authors/id/G/GA/GAAS/Digest= -SHA1-${PV}.tar.gz \ > >>> + file://run-ptest \ > >>> + " > >>> +SRC_URI[md5sum] =3D "bd22388f268434f2b24f64e28bf1aa35" > >>> +SRC_URI[sha256sum] =3D "68c1dac2187421f0eb7abf71452a06f190181b8fc4b2= 8ededf5b90296fb943cc" > >>> + > >>> +S =3D "${WORKDIR}/Digest-SHA1-${PV}" > >>> + > >>> +inherit cpan ptest > >>> + > >>> +do_install_ptest () { > >>> + cp -r ${B}/t ${D}${PTEST_PATH} > >>> +} > >>> + > >>> +BBCLASSEXTEND=3D"native" > >>> + > >>> +FILES_${PN}-dbg =3D+ "${libdir}/perl/vendor_perl/*/auto/Digest/SHA1/= =2Edebug/" > >> > >> --=20 > >> Regards, > >> Neil | Kai Kang > >> > >> --=20 > >> _______________________________________________ > >> Openembedded-devel mailing list > >> Openembedded-devel@lists.openembedded.org > >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel > > > > >=20 >=20 > --=20 > Regards, > Neil | Kai Kang >=20 > --=20 > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel --=20 Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com --IaumfLDne4EPF0pV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlPseLEACgkQN1Ujt2V2gBzovACeMAg1RjuCfaLELQB3FsFx1h4L JUkAoJWhH3RccUc1aXF37LekaXPhmQSY =bjxd -----END PGP SIGNATURE----- --IaumfLDne4EPF0pV--