From: Richard Cochran <richardcochran@gmail.com>
To: "fugang.duan@freescale.com" <fugang.duan@freescale.com>
Cc: "shawn.guo@linaro.org" <shawn.guo@linaro.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v2 1/1] net: fec: ptp: avoid register access when ipg clock is disabled
Date: Thu, 14 Aug 2014 11:12:59 +0200 [thread overview]
Message-ID: <20140814091259.GA11727@netboy> (raw)
In-Reply-To: <4977c4d325c949019549211d74c6982d@BLUPR03MB373.namprd03.prod.outlook.com>
On Thu, Aug 14, 2014 at 09:02:07AM +0000, fugang.duan@freescale.com wrote:
>
> I know your means. Even if cancel the time_keep work, ptp timer still is running and continutious.
> The time_keep work just to avoid timer overrun because FEC just support 32bit counter.
Right, so the time_keep must continue when the clock is running. It
does not depend on whether time stamping is enabled.
> And, you said "return an error", I don't know your mean.
> In addition, when clock is disabled, FEC ptp counter don't run any more.
You can return an error from your 'gettime' method.
Thanks,
Richard
next prev parent reply other threads:[~2014-08-14 9:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 4:55 [PATCH v2 0/1] net: fec: ptp: avoid register access when ipg clock is disabled Fugang Duan
2014-08-13 4:55 ` [PATCH v2 1/1] " Fugang Duan
2014-08-13 21:19 ` Richard Cochran
2014-08-14 1:28 ` fugang.duan
2014-08-14 8:10 ` Richard Cochran
2014-08-14 8:24 ` fugang.duan
2014-08-14 8:42 ` Richard Cochran
2014-08-14 9:02 ` fugang.duan
2014-08-14 9:12 ` Richard Cochran [this message]
2014-08-14 9:26 ` fugang.duan
2014-08-14 14:33 ` Richard Cochran
2014-08-15 3:23 ` fugang.duan
-- strict thread matches above, loose matches on Subject: below --
2021-02-25 20:55 Heiko Thiery
2021-02-25 22:34 ` kernel test robot
2021-02-25 22:34 ` kernel test robot
2021-02-25 21:15 Heiko Thiery
2021-02-26 7:22 ` Heiko Thiery
2021-02-26 15:23 ` Richard Cochran
2021-02-26 23:44 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140814091259.GA11727@netboy \
--to=richardcochran@gmail.com \
--cc=davem@davemloft.net \
--cc=fugang.duan@freescale.com \
--cc=netdev@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.