From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerome Glisse <j.glisse@gmail.com>
Subject: Re: Fence, timeline and android sync points
Date: Thu, 14 Aug 2014 10:12:06 -0400
Message-ID: <20140814141205.GB2000@gmail.com>
References: <20140812221340.GB5746@gmail.com>
 <20140813082822.GO10500@phenom.ffwll.local>
 <20140813133602.GA2666@gmail.com>
 <20140813155420.GG10500@phenom.ffwll.local>
 <20140813170719.GD2666@gmail.com>
 <CAF6AEGsU+LdksLgjzG0XY9d4hH6FO-MpkOmFdbLTuNPVHaTjDg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-qg0-f41.google.com (mail-qg0-f41.google.com
 [209.85.192.41])
 by gabe.freedesktop.org (Postfix) with ESMTP id A09776E6B8
 for <dri-devel@lists.freedesktop.org>; Thu, 14 Aug 2014 07:12:09 -0700 (PDT)
Received: by mail-qg0-f41.google.com with SMTP id q107so1071501qgd.14
 for <dri-devel@lists.freedesktop.org>; Thu, 14 Aug 2014 07:12:09 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CAF6AEGsU+LdksLgjzG0XY9d4hH6FO-MpkOmFdbLTuNPVHaTjDg@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Rob Clark <robdclark@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, Ben Skeggs <bskeggs@redhat.com>
List-Id: dri-devel@lists.freedesktop.org

On Thu, Aug 14, 2014 at 09:16:02AM -0400, Rob Clark wrote:
> On Wed, Aug 13, 2014 at 1:07 PM, Jerome Glisse <j.glisse@gmail.com> wrote:
> > So this is fundamentaly different, fence as they are now allow random driver
> > callback and this is bound to get ugly this is bound to lead to one driver
> > doing something that seems innocuous but turn out to break heavoc when call
> > from some other driver function.
> 
> 
> tbh, that seems solvable by some strict rules about what you can do in
> the callback.. ie. don't do anything you couldn't do in atomic, and
> don't signal another fence.. off the top of my head that seems
> sufficient.
> 
> If the driver getting the callback needs to do more, then it can
> always schedule a worker..
> 
> But I could certainly see the case where the driver waiting on fence
> sets everything up before installing the cb and then just needs to
> write one or a couple regs from the cb.

Yes sane code will do sane things, sadly i fear we can not enforce sane
code everywhere especialy with out of tree driver and i would rather
force there hand to only allow sane implementation. Providing call back
api obviously allows them to do crazy stuff.

> 
> BR,
> -R