All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	akpm@linux-foundation.org, rth@twiddle.net,
	ink@jurassic.park.msu.ru, mattst88@gmail.com,
	vgupta@synopsys.com, Geert Uytterhoeven <geert@linux-m68k.org>,
	Jean Delvare <jdelvare@suse.de>,
	linux@arm.linux.org.uk, catalin.marinas@arm.com,
	will.deacon@arm.com, hskinnemoen@gmail.com, egtvedt@samfundet.no,
	realmz6@gmail.com, msalter@redhat.com, a-jacquiot@ti.com,
	starvik@axis.com, jesper.nilsson@axis.com, dhowells@redhat.com,
	rkuo@codeaurora.org, tony.luck@intel.com, fenghua.yu@intel.com,
	takata@linux-m32r.org, james.hogan@imgtec.com,
	Michal Simek <monstr@monstr.eu>,
	yasutake.koichi@jp.panasonic.com, jonas@southpole.se,
	jejb@parisc-linux.org, deller@gmx.de,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	paulus@samba.org, mpe@ellerman.id.au, Mart
Subject: Re: [PATCH v3] arch: Kconfig: Let all architectures set endian explicitly
Date: Thu, 14 Aug 2014 20:04:18 +0200	[thread overview]
Message-ID: <20140814180418.GA20777@linux-mips.org> (raw)
In-Reply-To: <53ECE9DD.80004@gmail.com>

On Fri, Aug 15, 2014 at 12:54:53AM +0800, Chen Gang wrote:

> Normal architectures:
> 
>  - Big endian: avr32, frv, m68k, openrisc, parisc, s390, sparc
> 
>  - Little endian: alpha, blackfin, cris, hexagon, ia64, metag, mn10300,
>                   score, unicore32, x86
> 
>  - Choose in config time: arc, arm, arm64, c6x, m32r, mips, powerpc, sh

Nak for MIPS.  On MIPS Kconfig already always sets one of CPU_BIG_ENDIAN
and CPU_LITTLE_ENDIAN depending on platforms and where both endianess are
supported by a platform, user choice:

config FOO
	bool "foo"
	select SYS_SUPPORTS_LITTLE_ENDIAN

config FOO
	bool "foo"
	select SYS_SUPPORTS_BIG_ENDIAN
	select SYS_SUPPORTS_LITTLE_ENDIAN
[...]
choice
        prompt "Endianess selection"
        help
          Some MIPS machines can be configured for either little or big endian
          byte order. These modes require different kernels and a different
          Linux distribution.  In general there is one preferred byteorder for a
          particular system but some systems are just as commonly used in the
          one or the other endianness.

config CPU_BIG_ENDIAN
        bool "Big endian"
        depends on SYS_SUPPORTS_BIG_ENDIAN

config CPU_LITTLE_ENDIAN
        bool "Little endian"
        depends on SYS_SUPPORTS_LITTLE_ENDIAN
        help

endchoice

So I think you can just drop the MIPS segment from your patch.

  Ralf


WARNING: multiple messages have this Message-ID (diff)
From: Ralf Baechle <ralf@linux-mips.org>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	akpm@linux-foundation.org, rth@twiddle.net,
	ink@jurassic.park.msu.ru, mattst88@gmail.com,
	vgupta@synopsys.com, Geert Uytterhoeven <geert@linux-m68k.org>,
	Jean Delvare <jdelvare@suse.de>,
	linux@arm.linux.org.uk, catalin.marinas@arm.com,
	will.deacon@arm.com, hskinnemoen@gmail.com, egtvedt@samfundet.no,
	realmz6@gmail.com, msalter@redhat.com, a-jacquiot@ti.com,
	starvik@axis.com, jesper.nilsson@axis.com, dhowells@redhat.com,
	rkuo@codeaurora.org, tony.luck@intel.com, fenghua.yu@intel.com,
	takata@linux-m32r.org, james.hogan@imgtec.com,
	Michal Simek <monstr@monstr.eu>,
	yasutake.koichi@jp.panasonic.com, jonas@southpole.se,
	jejb@parisc-linux.org, deller@gmx.de,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	paulus@samba.org, mpe@ellerman.id.au,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	heiko.carstens@de.ibm.com, Liqin Chen <liqin.linux@gmail.com>,
	Lennox Wu <lennox.wu@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	cmetcalf@tilera.com, jdike@addtoit.com,
	Richard Weinberger <richard@nod.at>,
	gxt@mprc.pku.edu.cn, tglx@linutronix.de, mingo@redhat.com,
	hpa@zytor.com, chris@zankel.net, jcmvbkbc@gmail.com,
	linux390@de.ibm.com, x86@kernel.org, linux-alpha@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	adi-buildroot-devel@lists.sourceforge.net,
	linux-c6x-dev@linux-c6x.org, linux-cris-kernel@axis.com,
	linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org,
	linux-m32r@ml.linux-m32r.org, linux-m32r-ja@ml.linux-m32r.org,
	linux-m68k@vger.kernel.org, linux-metag@vger.kernel.org,
	linux-mips@linux-mips.org, linux-am33-list@redhat.com,
	linux@openrisc.net, linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
	sparclinux@vger.kernel.org,
	user-mode-linux-devel@lists.sourceforge.net,
	user-mode-linux-user@lists.sourceforge.net,
	linux-xtensa@linux-xtensa.org
Subject: Re: [PATCH v3] arch: Kconfig: Let all architectures set endian explicitly
Date: Thu, 14 Aug 2014 20:04:18 +0200	[thread overview]
Message-ID: <20140814180418.GA20777@linux-mips.org> (raw)
In-Reply-To: <53ECE9DD.80004@gmail.com>

On Fri, Aug 15, 2014 at 12:54:53AM +0800, Chen Gang wrote:

> Normal architectures:
> 
>  - Big endian: avr32, frv, m68k, openrisc, parisc, s390, sparc
> 
>  - Little endian: alpha, blackfin, cris, hexagon, ia64, metag, mn10300,
>                   score, unicore32, x86
> 
>  - Choose in config time: arc, arm, arm64, c6x, m32r, mips, powerpc, sh

Nak for MIPS.  On MIPS Kconfig already always sets one of CPU_BIG_ENDIAN
and CPU_LITTLE_ENDIAN depending on platforms and where both endianess are
supported by a platform, user choice:

config FOO
	bool "foo"
	select SYS_SUPPORTS_LITTLE_ENDIAN

config FOO
	bool "foo"
	select SYS_SUPPORTS_BIG_ENDIAN
	select SYS_SUPPORTS_LITTLE_ENDIAN
[...]
choice
        prompt "Endianess selection"
        help
          Some MIPS machines can be configured for either little or big endian
          byte order. These modes require different kernels and a different
          Linux distribution.  In general there is one preferred byteorder for a
          particular system but some systems are just as commonly used in the
          one or the other endianness.

config CPU_BIG_ENDIAN
        bool "Big endian"
        depends on SYS_SUPPORTS_BIG_ENDIAN

config CPU_LITTLE_ENDIAN
        bool "Little endian"
        depends on SYS_SUPPORTS_LITTLE_ENDIAN
        help

endchoice

So I think you can just drop the MIPS segment from your patch.

  Ralf

WARNING: multiple messages have this Message-ID (diff)
From: Ralf Baechle <ralf@linux-mips.org>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: linux-m32r-ja@ml.linux-m32r.org, linux-mips@linux-mips.org,
	linux-m68k@vger.kernel.org, a-jacquiot@ti.com,
	catalin.marinas@arm.com, linux@openrisc.net, will.deacon@arm.com,
	dhowells@redhat.com, jcmvbkbc@gmail.com, paulus@samba.org,
	hpa@zytor.com, sparclinux@vger.kernel.org,
	linux-hexagon@vger.kernel.org, linux-s390@vger.kernel.org,
	gxt@mprc.pku.edu.cn, Jean Delvare <jdelvare@suse.de>,
	egtvedt@samfundet.no, jonas@southpole.se,
	Liqin Chen <liqin.linux@gmail.com>,
	jesper.nilsson@axis.com, linux-am33-list@redhat.com,
	linux@arm.linux.org.uk, linux-c6x-dev@linux-c6x.org,
	"David S. Miller" <davem@davemloft.net>,
	linux-xtensa@linux-xtensa.org, takata@linux-m32r.org,
	x86@kernel.org, jejb@parisc-linux.org, mingo@redhat.com,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Lennox Wu <lennox.wu@gmail.com>,
	msalter@redhat.com, mattst88@gmail.com, hskinnemoen@gmail.com,
	fenghua.yu@intel.com, james.hogan@imgtec.com,
	Arnd Bergmann <arnd@arndb.de>,
	realmz6@gmail.com, heiko.carstens@de.ibm.com, jdike@addtoit.com,
	linux-alpha@vger.kernel.org,
	adi-buildroot-devel@lists.sourceforge.net, cmetcalf@tilera.com,
	starvik@axis.com, linux-m32r@ml.linux-m32r.org,
	ink@jurassic.park.msu.ru,
	user-mode-linux-user@lists.sourceforge.net, tglx@linutronix.de,
	linux-metag@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, rth@twiddle.net,
	chris@zankel.net, Michal Simek <monstr@monstr.eu>,
	tony.luck@intel.com, linux-ia64@vger.kernel.org,
	linux-parisc@vger.kernel.org, linux-cris-kernel@axis.com,
	vgupta@synopsys.com,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	rkuo@codeaurora.org, user-mode-linux-devel@lists.sourceforge.net,
	Richard Weinberger <richard@nod.at>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	linux390@de.ibm.com, akpm@linux-foundation.org,
	yasutake.koichi@jp.panasonic.com, linuxppc-dev@lists.ozlabs.org,
	deller@gmx.de
Subject: Re: [PATCH v3] arch: Kconfig: Let all architectures set endian explicitly
Date: Thu, 14 Aug 2014 20:04:18 +0200	[thread overview]
Message-ID: <20140814180418.GA20777@linux-mips.org> (raw)
In-Reply-To: <53ECE9DD.80004@gmail.com>

On Fri, Aug 15, 2014 at 12:54:53AM +0800, Chen Gang wrote:

> Normal architectures:
> 
>  - Big endian: avr32, frv, m68k, openrisc, parisc, s390, sparc
> 
>  - Little endian: alpha, blackfin, cris, hexagon, ia64, metag, mn10300,
>                   score, unicore32, x86
> 
>  - Choose in config time: arc, arm, arm64, c6x, m32r, mips, powerpc, sh

Nak for MIPS.  On MIPS Kconfig already always sets one of CPU_BIG_ENDIAN
and CPU_LITTLE_ENDIAN depending on platforms and where both endianess are
supported by a platform, user choice:

config FOO
	bool "foo"
	select SYS_SUPPORTS_LITTLE_ENDIAN

config FOO
	bool "foo"
	select SYS_SUPPORTS_BIG_ENDIAN
	select SYS_SUPPORTS_LITTLE_ENDIAN
[...]
choice
        prompt "Endianess selection"
        help
          Some MIPS machines can be configured for either little or big endian
          byte order. These modes require different kernels and a different
          Linux distribution.  In general there is one preferred byteorder for a
          particular system but some systems are just as commonly used in the
          one or the other endianness.

config CPU_BIG_ENDIAN
        bool "Big endian"
        depends on SYS_SUPPORTS_BIG_ENDIAN

config CPU_LITTLE_ENDIAN
        bool "Little endian"
        depends on SYS_SUPPORTS_LITTLE_ENDIAN
        help

endchoice

So I think you can just drop the MIPS segment from your patch.

  Ralf

  reply	other threads:[~2014-08-14 18:04 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-14 16:54 [PATCH v3] arch: Kconfig: Let all architectures set endian explicitly Chen Gang
2014-08-14 16:54 ` Chen Gang
2014-08-14 16:54 ` Chen Gang
2014-08-14 18:04 ` Ralf Baechle [this message]
2014-08-14 18:04   ` Ralf Baechle
2014-08-14 18:04   ` Ralf Baechle
2014-08-14 22:14   ` Chen Gang
2014-08-14 22:14     ` Chen Gang
2014-08-14 22:14     ` Chen Gang
2014-08-15  9:01     ` Chen Gang
2014-08-15  9:01       ` Chen Gang
2014-08-15  9:01       ` Chen Gang
2014-08-24  8:38       ` Chen Gang
2014-08-24  8:38         ` Chen Gang
2014-08-24  8:38         ` Chen Gang
2014-08-24  8:38         ` Chen Gang
2014-08-24  8:38         ` Chen Gang
2014-08-25 12:26         ` Chen Gang
2014-08-25 12:26           ` Chen Gang
2014-08-25 12:26           ` Chen Gang
2014-08-25 12:26           ` Chen Gang
2014-08-14 18:21 ` Vineet Gupta
2014-08-14 18:21   ` Vineet Gupta
2014-08-14 18:21   ` Vineet Gupta
2014-08-14 18:21   ` Vineet Gupta
2014-08-14 18:21   ` Vineet Gupta
2014-08-14 18:27   ` Lennox Wu
2014-08-14 18:27     ` Lennox Wu
2014-08-14 18:27     ` Lennox Wu
2014-08-14 22:22     ` Chen Gang
2014-08-14 22:22       ` Chen Gang
2014-08-14 22:22       ` Chen Gang
2014-08-14 23:12       ` Vineet Gupta
2014-08-14 23:12         ` Vineet Gupta
2014-08-14 23:12         ` Vineet Gupta
2014-08-14 23:12         ` Vineet Gupta
2014-08-14 23:12         ` Vineet Gupta
2014-08-15  1:29         ` Chen Gang
2014-08-15  1:29           ` Chen Gang
2014-08-15  1:29           ` Chen Gang
2014-08-15  1:29           ` Chen Gang
2014-08-15  1:47 ` Max Filippov
2014-08-15  1:47   ` Max Filippov
2014-08-15  1:47   ` Max Filippov
2014-08-15  1:52   ` Max Filippov
2014-08-15  1:52     ` Max Filippov
2014-08-15  1:52     ` Max Filippov
2014-08-15  2:06     ` Chen Gang
2014-08-15  2:06       ` Chen Gang
2014-08-15  2:06       ` Chen Gang
2014-08-15  2:06       ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140814180418.GA20777@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=a-jacquiot@ti.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=benh@kernel.crashing.org \
    --cc=catalin.marinas@arm.com \
    --cc=deller@gmx.de \
    --cc=dhowells@redhat.com \
    --cc=egtvedt@samfundet.no \
    --cc=fenghua.yu@intel.com \
    --cc=gang.chen.5i5j@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=hskinnemoen@gmail.com \
    --cc=ink@jurassic.park.msu.ru \
    --cc=james.hogan@imgtec.com \
    --cc=jdelvare@suse.de \
    --cc=jejb@parisc-linux.org \
    --cc=jesper.nilsson@axis.com \
    --cc=jonas@southpole.se \
    --cc=linux@arm.linux.org.uk \
    --cc=mattst88@gmail.com \
    --cc=monstr@monstr.eu \
    --cc=mpe@ellerman.id.au \
    --cc=msalter@redhat.com \
    --cc=paulus@samba.org \
    --cc=realmz6@gmail.com \
    --cc=rkuo@codeaurora.org \
    --cc=rth@twiddle.net \
    --cc=starvik@axis.com \
    --cc=takata@linux-m32r.org \
    --cc=tony.luck@intel.com \
    --cc=vgupta@synopsys.com \
    --cc=will.deacon@arm.com \
    --cc=yasutake.koichi@jp.panasonic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.