From: Jeff King <peff@peff.net>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, mflaschen@wikimedia.org
Subject: Re: [PATCH 1/2] fetch: convert argv_gc_auto to struct argv_array
Date: Thu, 14 Aug 2014 15:53:20 -0400 [thread overview]
Message-ID: <20140814195320.GA19337@peff.net> (raw)
In-Reply-To: <1408017065-17437-1-git-send-email-pclouds@gmail.com>
On Thu, Aug 14, 2014 at 06:51:04PM +0700, Nguyễn Thái Ngọc Duy wrote:
> - static const char *argv_gc_auto[] = {
> - "gc", "--auto", NULL,
> - };
> + struct argv_array argv_gc_auto = ARGV_ARRAY_INIT;
>
> packet_trace_identity("fetch");
>
> @@ -1198,7 +1196,8 @@ int cmd_fetch(int argc, const char **argv, const char *prefix)
> list.strdup_strings = 1;
> string_list_clear(&list, 0);
>
> - run_command_v_opt(argv_gc_auto, RUN_GIT_CMD);
> + argv_array_pushl(&argv_gc_auto, "gc", "--auto", NULL);
> + run_command_v_opt(argv_gc_auto.argv, RUN_GIT_CMD);
argv_array_clear() here afterwards?
Not a huge deal since we are about to exit, but in the name of
good hygiene.
-Peff
next prev parent reply other threads:[~2014-08-14 19:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 11:51 [PATCH 1/2] fetch: convert argv_gc_auto to struct argv_array Nguyễn Thái Ngọc Duy
2014-08-14 11:51 ` [PATCH 2/2] fetch: silence git-gc if --quiet is given Nguyễn Thái Ngọc Duy
2014-08-14 19:56 ` Jeff King
2014-08-15 12:09 ` Duy Nguyen
2014-08-14 19:53 ` Jeff King [this message]
2014-08-16 1:19 ` [PATCH v2 1/2] fetch: convert argv_gc_auto to struct argv_array Nguyễn Thái Ngọc Duy
2014-08-16 1:19 ` [PATCH v2 2/2] fetch: silence git-gc if --quiet is given Nguyễn Thái Ngọc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140814195320.GA19337@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=mflaschen@wikimedia.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.