All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: "fugang.duan-KZfg59tc24xl57MIdRCFDg@public.gmane.org"
	<fugang.duan-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: "wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org"
	<wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
	"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] i2c: imx: double check IIF in case interrupt lost
Date: Fri, 15 Aug 2014 09:18:14 +0200	[thread overview]
Message-ID: <20140815071814.GD5134@pengutronix.de> (raw)
In-Reply-To: <01dba3477e664c88a65e276a1c77c3e2-GeMU99GfrrsHjcGqcGfFzOO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org>

Hello,

On Fri, Aug 15, 2014 at 02:14:15AM +0000, fugang.duan-KZfg59tc24xl57MIdRCFDg@public.gmane.org wrote:
> I am sorry to tell you I don't have the reproduced platform for the issue since the
> Issue was found at one platform of customer of freescale, and I debug the issue with
> Customer, at last generate the patch for customer platform, test fine. So I want to
Does the customer use the -rt patch?

> Submit the patch. In our platforms, it is not easy to reproduce the issue.
I tend to not want the patch in mainline. IMHO a wrong workaround that
fixes the issue only for 95% is worse than an unfixed driver.
Maybe when analysing more exact the outcome is that the patch is right,
but if there is a race condition somewhere in the code it might be that
there is still a bug. Not being able to reproduce the problem doesn't
necessarily imply that the introduced change is a real fix.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

  parent reply	other threads:[~2014-08-15  7:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-14  8:29 [PATCH] i2c: imx: double check IIF in case interrupt lost Fugang Duan
     [not found] ` <1408004954-29418-1-git-send-email-b38611-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-08-14  9:42   ` Uwe Kleine-König
     [not found]     ` <20140814094204.GW5134-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-08-14 10:09       ` fugang.duan-KZfg59tc24xl57MIdRCFDg
     [not found]         ` <96d6e524bc524305904730df24bf878f-GeMU99GfrrsHjcGqcGfFzOO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org>
2014-08-14 19:27           ` Uwe Kleine-König
     [not found]             ` <20140814192702.GC5134-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-08-15  2:14               ` fugang.duan-KZfg59tc24xl57MIdRCFDg
     [not found]                 ` <01dba3477e664c88a65e276a1c77c3e2-GeMU99GfrrsHjcGqcGfFzOO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org>
2014-08-15  7:18                   ` Uwe Kleine-König [this message]
     [not found]                     ` <20140815071814.GD5134-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-08-19 14:53                       ` Wolfram Sang
2014-08-20  1:52                         ` fugang.duan-KZfg59tc24xl57MIdRCFDg
  -- strict thread matches above, loose matches on Subject: below --
2014-08-14  8:23 Fugang Duan
     [not found] ` <1408004588-22408-1-git-send-email-b38611-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-08-14  8:43   ` fugang.duan-KZfg59tc24xl57MIdRCFDg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140815071814.GD5134@pengutronix.de \
    --to=u.kleine-koenig-bicnvbalz9megne8c9+irq@public.gmane.org \
    --cc=fugang.duan-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.