From: Christoffer Dall <christoffer.dall@linaro.org>
To: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] arm_gic: Fix read of GICD_ICFGR
Date: Fri, 15 Aug 2014 14:03:22 +0200 [thread overview]
Message-ID: <20140815120322.GW10550@cbox> (raw)
In-Reply-To: <1407056027-7522-2-git-send-email-adam@os.inf.tu-dresden.de>
On Sun, Aug 03, 2014 at 10:53:45AM +0200, Adam Lackorzynski wrote:
> The GICD_ICFGR register covers 4 interrupts per byte.
>
> Signed-off-by: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
> ---
> hw/intc/arm_gic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c
> index 1532ef9..d2b1aaf 100644
> --- a/hw/intc/arm_gic.c
> +++ b/hw/intc/arm_gic.c
> @@ -372,7 +372,7 @@ static uint32_t gic_dist_readb(void *opaque, hwaddr offset)
> }
> } else if (offset < 0xf00) {
> /* Interrupt Configuration. */
> - irq = (offset - 0xc00) * 2 + GIC_BASE_IRQ;
> + irq = (offset - 0xc00) * 4 + GIC_BASE_IRQ;
> if (irq >= s->num_irq)
> goto bad_reg;
> res = 0;
> --
> 2.0.1
>
>
I guess we should consider only getting/setting the LSB of each field if
we're emulating a GICv1, but:
Acked-by: Christoffer Dall <christoffer.dall@linaro.org>
next prev parent reply other threads:[~2014-08-15 12:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-03 8:53 [Qemu-devel] [PATCH 0/3] arm_gic: Improve handling of GICD_ICFGR Adam Lackorzynski
2014-08-03 8:53 ` [Qemu-devel] [PATCH 1/3] arm_gic: Fix read " Adam Lackorzynski
2014-08-15 12:03 ` Christoffer Dall [this message]
2014-08-03 8:53 ` [Qemu-devel] [PATCH 2/3] arm_gic: SGIs for GICD_ICFGR are WI Adam Lackorzynski
2014-08-15 12:07 ` Christoffer Dall
2014-08-15 12:10 ` Adam Lackorzynski
2014-08-15 12:12 ` Christoffer Dall
2014-08-16 19:50 ` Adam Lackorzynski
2014-08-03 8:53 ` [Qemu-devel] [PATCH 3/3] arm_gic: GICD_ICFGR: Do not force edge-triggered PPIs Adam Lackorzynski
2014-08-03 13:21 ` [Qemu-devel] [PATCH 0/3] arm_gic: Improve handling of GICD_ICFGR Peter Maydell
2014-08-03 19:36 ` Christoffer Dall
2014-08-11 17:26 ` Adam Lackorzynski
2014-08-11 17:40 ` Christoffer Dall
-- strict thread matches above, loose matches on Subject: below --
2014-08-16 19:48 Adam Lackorzynski
2014-08-16 19:48 ` [Qemu-devel] [PATCH 1/3] arm_gic: Fix read " Adam Lackorzynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140815120322.GW10550@cbox \
--to=christoffer.dall@linaro.org \
--cc=adam@os.inf.tu-dresden.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.