From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 3/4] libftdi: Add dependency on atomic intrinsics
Date: Fri, 15 Aug 2014 22:58:20 +0200 [thread overview]
Message-ID: <20140815205820.GD25897@free.fr> (raw)
In-Reply-To: <1407510572-20603-3-git-send-email-Anton.Kolesov@synopsys.com>
Anton, All,
On 2014-08-08 19:09 +0400, Anton Kolesov spake thusly:
> Libftdi requires GCC built-in atomic functions which are architecture specific
> and may not be implemented.
>
> This fixes:
> http://autobuild.buildroot.net/results/6cb25ed954840109c9d0e582e922b0ba9d07e174/
>
> Signed-off-by: Anton Kolesov <Anton.Kolesov@synopsys.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
However, I do have a small eye-candy comment to make, see below...
[--SNIP--]
> diff --git a/package/openocd/Config.in b/package/openocd/Config.in
> index 7f96ef8..e692d2d 100644
> --- a/package/openocd/Config.in
> +++ b/package/openocd/Config.in
> @@ -14,11 +14,15 @@ comment "Adapters"
>
> config BR2_PACKAGE_OPENOCD_FT2XXX
> bool "FT2xxx/FT4xxx Based JTAG Programmer"
> + depends on BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS # libftdi
> select BR2_PACKAGE_LIBFTDI
> help
> Enable building support for FT2232 based devices
> using the libftdi driver, opensource alternate of FTD2XX
>
> +comment "FT2232 support needs a toolchain w/ atomic intrinsics"
I'd prefer we keep the same title for comment and options, such as:
comment "FT2xxx/FT4xxx support needs a toolchain w/ atomic intrinsics"
This can be fixed by whoever commits that, I guess no need to resend.
Regards,
Yann E. MORIN.
> + depends on !BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS
> +
> config BR2_PACKAGE_OPENOCD_JLINK
> bool "Segger J-Link JTAG Programmer"
> help
> --
> 1.8.4.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-08-15 20:58 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <In-Reply-To: <CAAXf6LURyGxEfQR+3g6xriwqUeE1E91Oav2X=r_C3YD66JzpEA@mail.gmail.com>
2014-08-08 15:09 ` [Buildroot] [PATCH v4 1/4] cairo: Add dependency on atomic intrinsics Anton Kolesov
2014-08-08 15:09 ` [Buildroot] [PATCH v4 2/4] pulseaudio: " Anton Kolesov
2014-08-15 20:54 ` Yann E. MORIN
2014-08-08 15:09 ` [Buildroot] [PATCH v4 3/4] libftdi: " Anton Kolesov
2014-08-15 20:58 ` Yann E. MORIN [this message]
2014-08-08 15:09 ` [Buildroot] [PATCH v4 4/4] msgpack: " Anton Kolesov
2014-08-15 21:04 ` Yann E. MORIN
2014-08-15 12:49 ` [Buildroot] [PATCH v4 1/4] cairo: " Anton Kolesov
2014-08-15 20:46 ` Yann E. MORIN
2014-07-28 18:02 [Buildroot] [PATCH 1/9] arc: Support option of atomic extension Anton Kolesov
2014-07-28 18:02 ` [Buildroot] [PATCH 2/9] cairo: arc: Disable if ARC atomics are disabled Anton Kolesov
2014-07-28 18:02 ` [Buildroot] [PATCH 3/9] jack2: " Anton Kolesov
2014-07-28 18:02 ` [Buildroot] [PATCH 4/9] pulseaudio: " Anton Kolesov
2014-07-28 18:02 ` [Buildroot] [PATCH 5/9] libftdi: " Anton Kolesov
2014-07-28 18:02 ` [Buildroot] [PATCH 6/9] msgpack: " Anton Kolesov
2014-07-28 18:02 ` [Buildroot] [PATCH 7/9] icu: " Anton Kolesov
2014-07-28 18:02 ` [Buildroot] [PATCH 8/9] libtorrent: " Anton Kolesov
2014-07-28 18:02 ` [Buildroot] [PATCH 9/9] thrift: " Anton Kolesov
2014-07-30 6:45 ` [Buildroot] [PATCH 1/9] arc: Support option of atomic extension Thomas Petazzoni
2014-07-31 13:24 ` [Buildroot] [PATCH v2 1/9] toolchain: Add config option for atomic intrinsics Anton Kolesov
2014-07-31 13:24 ` [Buildroot] [PATCH v2 2/9] cairo: Add dependency on " Anton Kolesov
2014-07-31 13:24 ` [Buildroot] [PATCH v2 3/9] jack2: " Anton Kolesov
2014-07-31 13:24 ` [Buildroot] [PATCH v2 4/9] pulseaudio: " Anton Kolesov
2014-07-31 13:24 ` [Buildroot] [PATCH v2 5/9] libftdi: " Anton Kolesov
2014-07-31 13:24 ` [Buildroot] [PATCH v2 6/9] msgpack: " Anton Kolesov
2014-07-31 13:24 ` [Buildroot] [PATCH v2 7/9] icu: " Anton Kolesov
2014-07-31 13:24 ` [Buildroot] [PATCH v2 8/9] libtorrent: " Anton Kolesov
2014-07-31 13:24 ` [Buildroot] [PATCH v2 9/9] thrift: " Anton Kolesov
2014-07-31 17:25 ` [Buildroot] [PATCH v2 1/9] toolchain: Add config option for " Yann E. MORIN
2014-07-31 18:05 ` Thomas Petazzoni
2014-08-03 9:32 ` Thomas Petazzoni
2014-08-04 12:16 ` [Buildroot] [PATCH v3 1/4] cairo: Add dependency on " Anton Kolesov
2014-08-04 12:16 ` [Buildroot] [PATCH v3 2/4] pulseaudio: " Anton Kolesov
2014-08-04 12:16 ` [Buildroot] [PATCH v3 3/4] libftdi: " Anton Kolesov
2014-08-04 12:16 ` [Buildroot] [PATCH v3 4/4] msgpack: " Anton Kolesov
2014-08-07 15:42 ` [Buildroot] [PATCH v3 1/4] cairo: " Thomas De Schampheleire
2014-08-04 12:17 ` [Buildroot] [PATCH] manual: Add atomic intrinsics to the dependencies section Anton Kolesov
2014-08-15 20:40 ` Yann E. MORIN
2014-08-15 22:17 ` Thomas Petazzoni
2014-08-15 22:23 ` Yann E. MORIN
2014-08-16 7:40 ` Thomas Petazzoni
2014-08-16 15:26 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140815205820.GD25897@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.