From: Dan Aloni <dan@kernelim.com>
To: Yaniv Gardi <ygardi@codeaurora.org>
Cc: James.Bottomley@HansenPartnership.com, hch@infradead.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-arm-msm@vger.kernel.org, santoshsy@gmail.com,
linux-scsi-owner@vger.kernel.org, subhashj@codeaurora.org,
noag@codeaurora.org, draviv@codeaurora.org,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Vinayak Holikatti <vinholikatti@gmail.com>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
Grant Likely <grant.likely@linaro.org>,
Sujit Reddy Thumma <sthumma@codeaurora.org>,
Sahitya Tummala <stummala@codeaurora.org>,
"open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>
Subject: Re: [PATCH v3] scsi: ufs-msm: add UFS controller support for Qualcomm MSM chips
Date: Sat, 16 Aug 2014 20:33:25 +0300 [thread overview]
Message-ID: <20140816173325.GA3961@gmail.com> (raw)
In-Reply-To: <1408026157-26972-1-git-send-email-ygardi@codeaurora.org>
On Thu, Aug 14, 2014 at 05:22:18PM +0300, Yaniv Gardi wrote:
> diff --git a/drivers/scsi/ufs/ufs-msm.h b/drivers/scsi/ufs/ufs-msm.h
> new file mode 100644
> index 0000000..6e93f1e
> --- /dev/null
> +++ b/drivers/scsi/ufs/ufs-msm.h
> @@ -0,0 +1,158 @@
[...]
> +};
> +
> +static LIST_HEAD(phy_list);
> +
Just noticed this via a quick glance - Seems that this variable is not
referenced by any of the compilation units, what's the purpose of it?
And as a static global in a shared private, each of the including
compilation units gets a copy, which I am not sure was intended
anyway.
--
Dan Aloni
next prev parent reply other threads:[~2014-08-16 17:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 14:22 [PATCH v3] scsi: ufs-msm: add UFS controller support for Qualcomm MSM chips Yaniv Gardi
2014-08-14 14:22 ` Yaniv Gardi
2014-08-14 14:27 ` Yaniv Gardi
2014-08-14 14:27 ` Yaniv Gardi
2014-08-14 15:03 ` Kumar Gala
2014-08-21 9:53 ` ygardi
2014-08-16 17:33 ` Dan Aloni [this message]
2014-08-24 13:51 ` Yaniv Gardi
2014-08-24 13:51 ` Yaniv Gardi
-- strict thread matches above, loose matches on Subject: below --
2014-08-22 0:50 subhashj
2014-08-22 0:50 ` subhashj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140816173325.GA3961@gmail.com \
--to=dan@kernelim.com \
--cc=JBottomley@parallels.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=devicetree@vger.kernel.org \
--cc=draviv@codeaurora.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=hch@infradead.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi-owner@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=noag@codeaurora.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=santoshsy@gmail.com \
--cc=sthumma@codeaurora.org \
--cc=stummala@codeaurora.org \
--cc=subhashj@codeaurora.org \
--cc=vinholikatti@gmail.com \
--cc=ygardi@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.