From: Dan Aloni <dan@kernelim.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org,
"Eric W. Biederman" <ebiederm@xmission.com>,
Trond Myklebust <trond.myklebust@primarydata.com>,
Stanislav Kinsbursky <skinsbursky@parallels.com>
Subject: Re: [PATCH] nfs: fix kernel warning when removing proc entry
Date: Sat, 16 Aug 2014 20:56:53 +0300 [thread overview]
Message-ID: <20140816175653.GA3884@gmail.com> (raw)
In-Reply-To: <1408056579-25255-1-git-send-email-xiyou.wangcong@gmail.com>
On Thu, Aug 14, 2014 at 03:49:39PM -0700, Cong Wang wrote:
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
> ---
> fs/nfs/client.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfs/client.c b/fs/nfs/client.c
> index 1c5ff6d..1c57202 100644
> --- a/fs/nfs/client.c
> +++ b/fs/nfs/client.c
> @@ -1429,7 +1429,7 @@ void nfs_fs_proc_net_exit(struct net *net)
>
> remove_proc_entry("volumes", nn->proc_nfsfs);
> remove_proc_entry("servers", nn->proc_nfsfs);
> - remove_proc_entry("fs/nfsfs", NULL);
> + remove_proc_entry("nfsfs", net->proc_net);
> }
nfs_fs_proc_net_init() has:
error_1:
remove_proc_entry("fs/nfsfs", NULL);
I think this needs fixing too, for consistency.
--
Dan Aloni
prev parent reply other threads:[~2014-08-16 17:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 22:49 [PATCH] nfs: fix kernel warning when removing proc entry Cong Wang
2014-08-16 17:56 ` Dan Aloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140816175653.GA3884@gmail.com \
--to=dan@kernelim.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=skinsbursky@parallels.com \
--cc=trond.myklebust@primarydata.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.