All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Arjun Sreedharan <arjun024@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata: propagate return value of scc_wait_after_reset
Date: Sun, 17 Aug 2014 07:27:05 -0400	[thread overview]
Message-ID: <20140817112705.GO9305@htj.dyndns.org> (raw)
In-Reply-To: <20140817111042.GN9305@htj.dyndns.org>

On Sun, Aug 17, 2014 at 07:10:42AM -0400, Tejun Heo wrote:
> On Sat, Aug 16, 2014 at 07:48:04PM +0530, Arjun Sreedharan wrote:
> > scc_bus_softreset not necessarily should return zero.
> > Propagate the error code.
> > 
> > Signed-off-by: Arjun Sreedharan <arjun024@gmail.com>
> 
> I reverted the change yesterday but didn't have time to reply.  Don't
> send patches you haven't even compile tested.  This is the most basic
> of your responsibilities when sending out patches.  Okay?
> 
> Applying the updated version to libata/for-3.17-fixes.

Gees, and your new patch doesn't even apply.  What are you doing?

-- 
tejun

  reply	other threads:[~2014-08-17 11:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <53ef6157.qX8Csumbm2zNx/EI%fengguang.wu@intel.com>
2014-08-16 14:18 ` [PATCH] ata: propagate return value of scc_wait_after_reset Arjun Sreedharan
2014-08-17 11:10   ` Tejun Heo
2014-08-17 11:27     ` Tejun Heo [this message]
2014-08-17 12:01       ` Arjun Sreedharan
2014-08-17 13:07         ` Tejun Heo
2014-08-16 10:17 Arjun Sreedharan
2014-08-16 11:37 ` Tejun Heo
2014-08-16 12:04   ` Arjun Sreedharan
2014-08-16 12:21     ` Tejun Heo
2014-08-16 12:25       ` Arjun Sreedharan
2014-08-16 12:50         ` Arjun Sreedharan
2014-08-16 12:55           ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140817112705.GO9305@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=arjun024@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.