From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by alsa0.perex.cz (Postfix) with ESMTP id 8E09A2650DA for ; Sun, 17 Aug 2014 16:42:18 +0200 (CEST) Date: Sun, 17 Aug 2014 19:50:28 +0530 From: "Subhransu S. Prusty" Message-ID: <20140817142023.GA12530@vinod.koul@linux.intel.com> References: <1405599225-31538-1-git-send-email-subhransu.s.prusty@intel.com> <20140729195043.GM17528@sirena.org.uk> <20140812060601.GA1115@vinod.koul@linux.intel.com> <20140812214822.GB17528@sirena.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140812214822.GB17528@sirena.org.uk> Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: Add merrifield machine driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: vinod.koul@intel.com, alsa-devel@alsa-project.org, Lars-Peter Clausen , lgirdwood@gmail.com List-ID: On Tue, Aug 12, 2014 at 10:48:22PM +0100, Mark Brown wrote: > On Tue, Aug 12, 2014 at 11:36:09AM +0530, Subhransu S. Prusty wrote: > > On Tue, Jul 29, 2014 at 08:50:43PM +0100, Mark Brown wrote: > > > On Thu, Jul 17, 2014 at 05:43:45PM +0530, Subhransu S. Prusty wrote: > > > > > + /* Force enable VMID to avoid cold latency constraints */ > > > > + snd_soc_dapm_force_enable_pin(&card->dapm, "VMID"); > > > > + snd_soc_dapm_sync(&card->dapm); > > > > This looks like you're open coding a version of wm8994_vmid_mode(). > > > Though that might need some tuning for systems that really have no > > > single ended outputs. > > > VMID has a larget settling time. Keep it ON here to avoid the delay. Any > > better way of doing this? > > Look at what wm8994_vmid_mode() does... If I understand correctly need to move this enabling/disabling of VMID to wm8994_vmid_mode(). -- _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel