From: Christoffer Dall <christoffer.dall@linaro.org>
To: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/4] arm_gic: Use GIC_NR_SGIS constant
Date: Mon, 18 Aug 2014 16:14:07 +0200 [thread overview]
Message-ID: <20140818141407.GH19635@cbox> (raw)
In-Reply-To: <1408367280-5093-5-git-send-email-adam@os.inf.tu-dresden.de>
On Mon, Aug 18, 2014 at 03:08:00PM +0200, Adam Lackorzynski wrote:
> Use constant rather than a plain number.
>
> Signed-off-by: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
> ---
> hw/intc/arm_gic_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/intc/arm_gic_common.c b/hw/intc/arm_gic_common.c
> index 6d884ec..18b01ba 100644
> --- a/hw/intc/arm_gic_common.c
> +++ b/hw/intc/arm_gic_common.c
> @@ -128,7 +128,7 @@ static void arm_gic_common_reset(DeviceState *dev)
> s->running_priority[i] = 0x100;
> s->cpu_enabled[i] = false;
> }
> - for (i = 0; i < 16; i++) {
> + for (i = 0; i < GIC_NR_SGIS; i++) {
> GIC_SET_ENABLED(i, ALL_CPU_MASK);
> GIC_SET_EDGE_TRIGGER(i);
> }
> --
> 2.1.0.rc1
>
Acked-by: Christoffer Dall <christoffer.dall@linaro.org>
prev parent reply other threads:[~2014-08-18 14:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 13:07 [Qemu-devel] [PATCH 0/4] arm_gic: Improve handling of GICD_ICFGR Adam Lackorzynski
2014-08-18 13:07 ` [Qemu-devel] [PATCH 1/4] arm_gic: Fix read " Adam Lackorzynski
2014-08-18 13:07 ` [Qemu-devel] [PATCH 2/4] arm_gic: GICD_ICFGR: Write model only for pre v1 GICs Adam Lackorzynski
2014-08-18 13:07 ` [Qemu-devel] [PATCH 3/4] arm_gic: Do not force PPIs to edge-triggered mode Adam Lackorzynski
2014-08-18 13:08 ` [Qemu-devel] [PATCH 4/4] arm_gic: Use GIC_NR_SGIS constant Adam Lackorzynski
2014-08-18 14:14 ` Christoffer Dall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140818141407.GH19635@cbox \
--to=christoffer.dall@linaro.org \
--cc=adam@os.inf.tu-dresden.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.