From: Ralf Baechle <ralf@linux-mips.org>
To: Joshua Kinard <kumba@gentoo.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Linux MIPS List <linux-mips@linux-mips.org>
Subject: Re: [PATCH] MIPS: IP28: Correct IO_BASE in mach-ip28/spaces.h for proper ioremap
Date: Tue, 19 Aug 2014 10:00:34 +0200 [thread overview]
Message-ID: <20140819080034.GA11547@linux-mips.org> (raw)
In-Reply-To: <53F2BC86.8000506@gentoo.org>
On Mon, Aug 18, 2014 at 10:55:02PM -0400, Joshua Kinard wrote:
> --- a/arch/mips/include/asm/mach-ip28/spaces.h
> +++ b/arch/mips/include/asm/mach-ip28/spaces.h
> @@ -18,7 +18,7 @@
> #define PHYS_OFFSET _AC(0x20000000, UL)
>
> #define UNCAC_BASE _AC(0xc0000000, UL) /* 0xa0000000 + PHYS_OFFSET */
> -#define IO_BASE UNCAC_BASE
> +#define IO_BASE _AC(0x9000000000000000, UL)
>
> #include <asm/mach-generic/spaces.h>
I think the real culprit is not the definition of IO_BASE but of
UNCAC_BASE. 0xc0000000UL is KSEG2 for a 32 bit kernel - but for a 64 bit
kernel UNCAC_BASE should be defined as _AC(0x9000000000000000, UL).
Which are the defaults in <asm/mach-generic/spaces.h> so just deleting
both UNCAC_BASE and IO_BASE from mach-ip28/spaces.h should fix things?
Ralf
next prev parent reply other threads:[~2014-08-19 8:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 2:55 [PATCH] MIPS: IP28: Correct IO_BASE in mach-ip28/spaces.h for proper ioremap Joshua Kinard
2014-08-19 8:00 ` Ralf Baechle [this message]
2014-08-19 8:12 ` Ralf Baechle
2014-08-19 10:05 ` Thomas Bogendoerfer
2014-08-19 20:01 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140819080034.GA11547@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=kumba@gentoo.org \
--cc=linux-mips@linux-mips.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.