From mboxrd@z Thu Jan 1 00:00:00 1970 From: greg@kroah.com (Greg KH) Date: Tue, 19 Aug 2014 04:16:41 -0500 Subject: [PATCH v2] imx-drm: imx-drm-core: add suspend/resume support In-Reply-To: <20140819080808.GB30401@n2100.arm.linux.org.uk> References: <1406269240-24622-1-git-send-email-shawn.guo@freescale.com> <20140818062532.GC2114@dragon> <20140819080808.GB30401@n2100.arm.linux.org.uk> Message-ID: <20140819091641.GA1349@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Aug 19, 2014 at 09:08:08AM +0100, Russell King - ARM Linux wrote: > On Mon, Aug 18, 2014 at 02:25:34PM +0800, Shawn Guo wrote: > > On Fri, Jul 25, 2014 at 02:20:40PM +0800, Shawn Guo wrote: > > > HDMI currently stops working after a system suspend/resume cycle. The > > > cause is that the mode setting states in hardware gets lost and isn't > > > restored across the suspend/resume cycle. > > > > > > The patch adds a very basic suspend/resume support to imx-drm driver, > > > and calls drm_helper_resume_force_mode() in .resume hook to restore the > > > mode setting states, so that HDMI can continue working after a system > > > suspend/resume cycle. > > > > > > Signed-off-by: Shawn Guo > > > > Hi Russell, > > > > What's your take on this patch? > > I've mostly stepped away from collecting imx-drm patches for Greg, and > I'm probably going to be dropping those patches which I had queued up > a while back for Greg. > > Greg wishes me to use signed tags for pull requests. This is not how I > work, and would mean having to rewrite a bunch of my scripts to cater > for Greg's special case. No one else requires this. "special case"? That's what Linus wants from everyone as well, how hard is it to add a simple line to your scripts that does: git tag -u ${KEY} -s ${TREE} ${BRANCH} before doing: git request-pull .... ${TREE} It's just a simple one line addition, right? What am I missing here? > I haven't had the time to start looking at what this would require > during the last three months, so the only other solution is to step > down from dealing with imx-drm patches. I never said I would refuse to take patches from you if you didn't do this, I only asked if you could, as it makes me feel more comfortable taking pull requests from you as you are the only one that doesn't do this for trees I pull. You should be using signed tags for your other trees as well, it's not just me who should be asking you for this... thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v2] imx-drm: imx-drm-core: add suspend/resume support Date: Tue, 19 Aug 2014 04:16:41 -0500 Message-ID: <20140819091641.GA1349@kroah.com> References: <1406269240-24622-1-git-send-email-shawn.guo@freescale.com> <20140818062532.GC2114@dragon> <20140819080808.GB30401@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by gabe.freedesktop.org (Postfix) with ESMTP id E8CE76E306 for ; Tue, 19 Aug 2014 02:17:22 -0700 (PDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by gateway1.nyi.internal (Postfix) with ESMTP id 045B12072B for ; Tue, 19 Aug 2014 05:17:19 -0400 (EDT) Content-Disposition: inline In-Reply-To: <20140819080808.GB30401@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Russell King - ARM Linux Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, Shawn Guo List-Id: dri-devel@lists.freedesktop.org On Tue, Aug 19, 2014 at 09:08:08AM +0100, Russell King - ARM Linux wrote: > On Mon, Aug 18, 2014 at 02:25:34PM +0800, Shawn Guo wrote: > > On Fri, Jul 25, 2014 at 02:20:40PM +0800, Shawn Guo wrote: > > > HDMI currently stops working after a system suspend/resume cycle. The > > > cause is that the mode setting states in hardware gets lost and isn't > > > restored across the suspend/resume cycle. > > > > > > The patch adds a very basic suspend/resume support to imx-drm driver, > > > and calls drm_helper_resume_force_mode() in .resume hook to restore the > > > mode setting states, so that HDMI can continue working after a system > > > suspend/resume cycle. > > > > > > Signed-off-by: Shawn Guo > > > > Hi Russell, > > > > What's your take on this patch? > > I've mostly stepped away from collecting imx-drm patches for Greg, and > I'm probably going to be dropping those patches which I had queued up > a while back for Greg. > > Greg wishes me to use signed tags for pull requests. This is not how I > work, and would mean having to rewrite a bunch of my scripts to cater > for Greg's special case. No one else requires this. "special case"? That's what Linus wants from everyone as well, how hard is it to add a simple line to your scripts that does: git tag -u ${KEY} -s ${TREE} ${BRANCH} before doing: git request-pull .... ${TREE} It's just a simple one line addition, right? What am I missing here? > I haven't had the time to start looking at what this would require > during the last three months, so the only other solution is to step > down from dealing with imx-drm patches. I never said I would refuse to take patches from you if you didn't do this, I only asked if you could, as it makes me feel more comfortable taking pull requests from you as you are the only one that doesn't do this for trees I pull. You should be using signed tags for your other trees as well, it's not just me who should be asking you for this... thanks, greg k-h