All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: jogo@openwrt.org, zajec5@gmail.com, linux-mips@linux-mips.org
Subject: Re: [PATCH v2] MIPS: BCM47XX: fix reboot problem on BCM4705/BCM4785
Date: Tue, 19 Aug 2014 12:12:22 +0200	[thread overview]
Message-ID: <20140819101222.GC11547@linux-mips.org> (raw)
In-Reply-To: <1408392076-308-1-git-send-email-hauke@hauke-m.de>

On Mon, Aug 18, 2014 at 10:01:16PM +0200, Hauke Mehrtens wrote:

> This adds some code based on code from the Broadcom GPL tar to fix the
> reboot problems on BCM4705/BCM4785. I tried rebooting my device for ~10
> times and have never seen a problem. This reverts the changes in the
> previous commit and adds the real fix as suggested by Rafał.
> 
> Setting bit 22 in Reg 22, sel 4 puts the BIU (Bus Interface Unit) into
> async mode.

I'm going to apply this - but in the future, when reverting a patch please
don't fold new changes together with the revert, rather send a revert.

Thanks,

  Ralf

      reply	other threads:[~2014-08-19 10:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-18 20:01 [PATCH v2] MIPS: BCM47XX: fix reboot problem on BCM4705/BCM4785 Hauke Mehrtens
2014-08-19 10:12 ` Ralf Baechle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140819101222.GC11547@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=hauke@hauke-m.de \
    --cc=jogo@openwrt.org \
    --cc=linux-mips@linux-mips.org \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.