From: Vinod Koul <vinod.koul@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
"Subhransu S. Prusty" <subhransu.s.prusty@intel.com>,
lgirdwood@gmail.com
Subject: Re: [v2 1/5] ASoC: Intel: mrfld - add the dsp sst driver
Date: Tue, 19 Aug 2014 21:32:23 +0530 [thread overview]
Message-ID: <20140819160223.GR13288@intel.com> (raw)
In-Reply-To: <20140819161117.GJ24407@sirena.org.uk>
[-- Attachment #1.1: Type: text/plain, Size: 1061 bytes --]
On Tue, Aug 19, 2014 at 11:11:17AM -0500, Mark Brown wrote:
> On Tue, Aug 19, 2014 at 04:07:03PM +0530, Subhransu S. Prusty wrote:
>
> > sound/soc/intel/sst/sst.c | 443 ++++++++++++++
> > sound/soc/intel/sst/sst.h | 654 ++++++++++++++++++++
> > sound/soc/intel/sst/sst_drv_interface.c | 475 +++++++++++++++
> > sound/soc/intel/sst/sst_ipc.c | 373 ++++++++++++
> > sound/soc/intel/sst/sst_loader.c | 975 ++++++++++++++++++++++++++++++
> > sound/soc/intel/sst/sst_pvt.c | 207 +++++++
> > sound/soc/intel/sst/sst_stream.c | 526 ++++++++++++++++
> > 11 files changed, 3696 insertions(+)
>
> As I indicated last time please split this up into smaller patches, for
> example one per file. This is an enormous amount of code to look at in
> a single commit which is really going to slow down review.
Sorry looks like Shubranshu missed it. Yes we were supposed to do that so
you can ignore this series and we will resubmit with split of 1st patch :)
--
~Vinod
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-08-19 16:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 10:37 [v2 0/5] ASoC: Intel: sst - add the merrifield DSP driver Subhransu S. Prusty
2014-08-19 10:37 ` [v2 1/5] ASoC: Intel: mrfld - add the dsp sst driver Subhransu S. Prusty
2014-08-19 16:11 ` Mark Brown
2014-08-19 16:02 ` Vinod Koul [this message]
2014-08-19 10:37 ` [v2 2/5] ASoC: Intel: sst: add power management handling Subhransu S. Prusty
2014-08-19 10:37 ` [v2 3/5] ASoC: Intel: sst: load firmware using async callback Subhransu S. Prusty
2014-08-19 10:37 ` [v2 4/5] ASoC: mfld-compress: Use dedicated function instead of ioctl Subhransu S. Prusty
2014-08-19 10:37 ` [v2 5/5] ASoC: Intel: sst - add compressed ops handling Subhransu S. Prusty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140819160223.GR13288@intel.com \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=subhransu.s.prusty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.