From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Tue, 19 Aug 2014 17:38:42 +0200 Subject: [U-Boot] [UBOOT RFC PATCH 02/13] usb: gadget: udc-core: Add minimal udc-core from linux kernel In-Reply-To: <20140819152808.GJ16085@saruman.home> References: <1408372115-4570-1-git-send-email-kishon@ti.com> <1408372115-4570-3-git-send-email-kishon@ti.com> <20140819105229.0559147a@amdc2363> <53F36ACC.4050609@ti.com> <20140819152808.GJ16085@saruman.home> Message-ID: <20140819173842.1635c769@amdc2363> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Felipe, Kishon > On Tue, Aug 19, 2014 at 08:48:36PM +0530, Kishon Vijay Abraham I > wrote: > > Hi Lukasz, > > > > On Tuesday 19 August 2014 02:22 PM, Lukasz Majewski wrote: > > > Hi Kishon, > > > > > >> In order to support multiple USB device controllers in uboot, > > >> udc-core is needed. > > > > > > Is it? In u-boot at best only one UDC is operational at a time. > > > > I didn't mean operational at the same time. dra7xx has 4 USB > > controllers and we should allow the user to use any USB port for > > DFU. > > but from u-boot's perspective, that can (should?) be a build-time > choice. That user, certainly, won't need more than one port active for > booting, right ? This is my point. We are working with the bootloader. Some things here are set at board configuration and aren't changed afterwards (like only UDC 0 output is wired out). The dfu/ums commands give you the ability to specify controller if you need such option. > > > >> udc-core also helps to cleanly link the USB > > >> peripheral driver with the gadget driver. Hence Ported minimal > > >> udc-core from linux kernel. > > > > > > I'd appreciate the exact SHA for this udc-core.c code. And the SHA > > > should be from some already released mainline code (like final > > > 3.16), not any private branch nor linux-next. > > > > We can't have the exact udc-core.c from linux kernel as it deals > > with kernel driver model stuff and vfs which is not needed for > > kernel. Trying to have the exact same code from kernel complicates > > it. > > what he means is to point to the SHA1 when you originally forked the > code from kernel. Sure udc-core can't be the same, but you based off > of a known commit ID frmo the kernel. > +1 The best way is to grab original source from mailine kernel, and then provide patch which adjust it. In this way we have clean trace from where the code comes. -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group