From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1] Arm64: Remove unnecessary keyword 'extern' from proc-fns.h
Date: Tue, 19 Aug 2014 21:29:20 +0100 [thread overview]
Message-ID: <20140819202920.GA20112@arm.com> (raw)
In-Reply-To: <1408477371.22761.145.camel@smoke>
On Tue, Aug 19, 2014 at 08:42:51PM +0100, Geoff Levand wrote:
> On Tue, 2014-08-19 at 14:28 +0530, Arun Chandran wrote:
> > As the functions have external linkage by default, the extern
> > keyword is irrelevant here.
>
> extern is used to say that the storage of a variable is done
> somewhere else. It marks a statement as a declaration when
> there is ambiguity about if the statement is a definition or
> declaration. Since function prototypes are not definitions,
> extern doesn't have any effect on them. It is not really
> related to linkage or scope.
Regardless, this patch doesn't apply.
Will
prev parent reply other threads:[~2014-08-19 20:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 8:58 [PATCH v1] Arm64: Remove unnecessary keyword 'extern' from proc-fns.h Arun Chandran
2014-08-19 19:42 ` Geoff Levand
2014-08-19 20:29 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140819202920.GA20112@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.