From: Jeff King <peff@peff.net>
To: Chris Packham <judge.packham@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, Babak M <babak@melon.com.au>,
git <git@vger.kernel.org>
Subject: Re: Issuing warning when hook does not have execution permission
Date: Wed, 20 Aug 2014 06:19:22 -0400 [thread overview]
Message-ID: <20140820101921.GA21527@peff.net> (raw)
In-Reply-To: <CAFOYHZCGQj1vaZfOpFXHpuf-OjTB5RXRN_37O2EkQFRvow-RfA@mail.gmail.com>
On Wed, Aug 20, 2014 at 08:55:52PM +1200, Chris Packham wrote:
> I actually find the existing behaviour useful. If I want to disable a
> hook to I can just chmod -x .git/hook/... and I then chmod +x it when
> I want to re-enable it. I guess I could live with an extra warning as
> long as the command still succeeds.
You could do the same thing "mv $hook $hook.disabled" but it involves
retraining your fingers. I kind of agree that the existing system of
respecting the executable bit is nice, though: it does what you told it
to do, and a misconfiguration is your problem, not the system's. It's
perhaps worth changing if people frequently get the executable-bit thing
wrong, but I don't know whether they do or not.
I kind of feel like we had a similar discussion around items in PATH,
but I don't remember how it resolved.
-Peff
next prev parent reply other threads:[~2014-08-20 10:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 6:05 Issuing warning when hook does not have execution permission Babak M
2014-08-19 8:00 ` Jeff King
2014-08-19 16:52 ` Junio C Hamano
2014-08-20 8:55 ` Chris Packham
2014-08-20 10:19 ` Jeff King [this message]
2014-08-20 17:51 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140820101921.GA21527@peff.net \
--to=peff@peff.net \
--cc=babak@melon.com.au \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=judge.packham@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.