From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH] mfd: twl4030-power: Fix PM idle pin configuration to not conflict with regulators Date: Wed, 20 Aug 2014 13:30:30 +0100 Message-ID: <20140820123030.GL4266@lee--X1> References: <20140819152405.GA12002@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20140819152405.GA12002@atomide.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Tony Lindgren Cc: Aaro Koskinen , Sebastian Reichel , Pavel Machek , Pali =?iso-8859-1?Q?Roh=E1r?= , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org T24gVHVlLCAxOSBBdWcgMjAxNCwgVG9ueSBMaW5kZ3JlbiB3cm90ZToKCj4gQ29tbWl0IDQzZmVm NDdmOTRhMSAobWZkOiB0d2w0MDMwLXBvd2VyOiBBZGQgYSBjb25maWd1cmF0aW9uIHRvIHR1cm4K PiBvZmYgb3NjaWxsYXRvciBkdXJpbmcgb2ZmLWlkbGUpIGFkZGVkIHN1cHBvcnQgZm9yIGNvbmZp Z3VyaW5nIHRoZSBQTUlDCj4gdG8gY3V0IG9mZiByZXNvdXJjZXMgZHVyaW5nIGRlZXBlciBpZGxl IHN0YXRlcyB0byBzYXZlIHBvd2VyLgo+IAo+IFRoaXMgaG93ZXZlciBjYXVzZWQgcmVncmVzc2lv biBmb3IgbjkwMCBkaXNwbGF5IHBvd2VyIHRoYXQgbmVlZGVkIHRoZQo+IFBNSUMgY29uZmlndXJh dGlvbiB0byBiZSBkaXNhYmxlZCB3aXRoIGNvbW1pdCBkOTM3Njc4YWI2MjUgKEFSTTogZHRzOgo+ IFJldmVydCBlbmFibGluZyBvZiB0d2wgY29uZmlndXJhdGlvbiBmb3IgbjkwMCkuCj4gCj4gVHVy bnMgb3V0IHRoZSByb290IGNhdXNlIG9mIHRoZSBwcm9ibGVtIGlzIHRoYXQgd2UgbXVzdCB1c2UK PiBUV0w0MDMwX1JFU0NPTkZJR19VTkRFRiBpbnN0ZWFkIG9mIERFVl9HUlBfTlVMTCB0byBhdm9p ZCBkaXNhYmxpbmcKPiByZWd1bGF0b3JzIHRoYXQgbWF5IGhhdmUgYmVlbiBlbmFibGVkIGJlZm9y ZSB0aGUgaW5pdCBmdW5jdGlvbgo+IGZvciB0d2w0MDMwLXBvd2VyLmMgcnVucy4gV2l0aCBUV0w0 MDMwX1JFU0NPTkZJR19VTkRFRiB3ZSBsZXQgdGhlCj4gcmVndWxhdG9yIGZyYW1ld29yayBjb250 cm9sIHRoZSByZWd1bGF0b3JzIGxpa2UgaXQgc2hvdWxkLiBIZXJlIHdlCj4gbmVlZCB0byBvbmx5 IGNvbmZpZ3VyZSB0aGUgc3lzX2Nsa2VuIGFuZCBzeXNfb2ZmX21vZGUgdHJpZ2dlcnMgZm9yCj4g dGhlIHJlZ3VsYXRvcnMgdGhhdCBjYW5ub3QgYmUgZG9uZSBieSB0aGUgcmVndWxhdG9yIGZyYW1l d29yayBhcwo+IGl0J3Mgbm90IHJ1bm5pbmcgYXQgdGhhdCBwb2ludC4KPiAKPiBUaGlzIGFsbG93 cyB1cyB0byBlbmFibGUgdGhlIFBNSUMgY29uZmlndXJhdGlvbiBmb3IgbjkwMC4KPiAKPiBGaXhl czogNDNmZWY0N2Y5NGExIChtZmQ6IHR3bDQwMzAtcG93ZXI6IEFkZCBhIGNvbmZpZ3VyYXRpb24g dG8gdHVybiBvZmYgb3NjaWxsYXRvciBkdXJpbmcgb2ZmLWlkbGUpCj4gQ2M6IHN0YWJsZUB2Z2Vy Lmtlcm5lbC5vcmcgIyB2My4xNgo+IFNpZ25lZC1vZmYtYnk6IFRvbnkgTGluZGdyZW4gPHRvbnlA YXRvbWlkZS5jb20+Cj4gCj4gLS0tCj4gCj4gTGVlLCBjYW4geW91IHBsZWFzZSBwaWNrIHRoaXMg b25lIGZvciB0aGUgdjMuMTctcmMgc2VyaWVzPwoKQXBwbGllZCB3aXRoIEFhcm8ncyBUZXN0ZWQt YnkuCgotLSAKTGVlIEpvbmVzCkxpbmFybyBTVE1pY3JvZWxlY3Ryb25pY3MgTGFuZGluZyBUZWFt IExlYWQKTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFSTSBTb0NzCkZv bGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBs aXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Wed, 20 Aug 2014 13:30:30 +0100 Subject: [PATCH] mfd: twl4030-power: Fix PM idle pin configuration to not conflict with regulators In-Reply-To: <20140819152405.GA12002@atomide.com> References: <20140819152405.GA12002@atomide.com> Message-ID: <20140820123030.GL4266@lee--X1> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 19 Aug 2014, Tony Lindgren wrote: > Commit 43fef47f94a1 (mfd: twl4030-power: Add a configuration to turn > off oscillator during off-idle) added support for configuring the PMIC > to cut off resources during deeper idle states to save power. > > This however caused regression for n900 display power that needed the > PMIC configuration to be disabled with commit d937678ab625 (ARM: dts: > Revert enabling of twl configuration for n900). > > Turns out the root cause of the problem is that we must use > TWL4030_RESCONFIG_UNDEF instead of DEV_GRP_NULL to avoid disabling > regulators that may have been enabled before the init function > for twl4030-power.c runs. With TWL4030_RESCONFIG_UNDEF we let the > regulator framework control the regulators like it should. Here we > need to only configure the sys_clken and sys_off_mode triggers for > the regulators that cannot be done by the regulator framework as > it's not running at that point. > > This allows us to enable the PMIC configuration for n900. > > Fixes: 43fef47f94a1 (mfd: twl4030-power: Add a configuration to turn off oscillator during off-idle) > Cc: stable at vger.kernel.org # v3.16 > Signed-off-by: Tony Lindgren > > --- > > Lee, can you please pick this one for the v3.17-rc series? Applied with Aaro's Tested-by. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog