From: Egbert Eich <eich@freedesktop.org>
To: "Y.C. Chen" <yc_chen@aspeedtech.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] Fixed 1600x900 Display Issue
Date: Thu, 21 Aug 2014 12:12:19 +0200 [thread overview]
Message-ID: <20140821101218.GB28930@debian> (raw)
In-Reply-To: <1408439451-21060-1-git-send-email-yc_chen@aspeedtech.com>
Just noticed two other things:
On Tue, Aug 19, 2014 at 05:10:51PM +0800, Y.C. Chen wrote:
> --- a/drivers/gpu/drm/ast/ast_tables.h
> +++ b/drivers/gpu/drm/ast/ast_tables.h
> @@ -72,6 +72,7 @@
> static struct ast_vbios_dclk_info dclk_table[] = {
> {0x2C, 0xE7, 0x03}, /* 00: VCLK25_175 */
> @@ -99,6 +100,8 @@ static struct ast_vbios_dclk_info dclk_table[] = {
> {0x25, 0x65, 0x80}, /* 16: VCLK88.75 */
> {0x77, 0x58, 0x80}, /* 17: VCLK119 */
> {0x32, 0x67, 0x80}, /* 18: VCLK85_5 */
> + {0x6a, 0x6d, 0x80}, /* 19: VCLK97_75 */
This addition fixes another bug: without this entry the unpatched code may run
off the end of the list.
Maybe you can provide this addition (just this one line) in a separate
patch, explaining in the changelog what it fixes.
> + {0x3b, 0x2c, 0x81}, /* 1A: VCLK118_25 */
> };
>
> /* 16:10 */
> static struct ast_vbios_enhtable res_1280x800[] = {
> - {1440, 1280, 48, 32, 823, 800, 3, 6, VCLK71, /* 60Hz RB */
> - (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo), 60, 1, 35 },
> - {1680, 1280, 72,128, 831, 800, 3, 6, VCLK83_5, /* 60Hz */
> - (SyncPN | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo), 60, 1, 0x35 },
> - {1680, 1280, 72,128, 831, 800, 3, 6, VCLK83_5, /* 60Hz */
> - (SyncPN | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo), 0xFF, 1, 0x35 },
> -
> + {1680, 1280, 72,128, 831, 800, 3, 6, VCLK83_5, /* 60Hz CVT */
> + (SyncPN | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo), 60, 1, 0x35 },
> + {1440, 1280, 48, 32, 823, 800, 3, 6, VCLK71, /* 60Hz CVT RB */
> + (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo), 60, 2, 35 },
_______^^
This was like this in the code before - but shouldn't this read: 0x35?
> + {1440, 1280, 48, 32, 823, 800, 3, 6, VCLK71, /* 60Hz CVT RB */
> + (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo), 0xFF, 2, 35 },
_______^^
Same here.
prev parent reply other threads:[~2014-08-21 10:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 9:10 [PATCH] Fixed 1600x900 Display Issue Y.C. Chen
2014-08-21 9:06 ` Egbert Eich
2014-08-21 9:27 ` YC Chen
2014-08-21 10:12 ` Egbert Eich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140821101218.GB28930@debian \
--to=eich@freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=yc_chen@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.