From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v4 1/4] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver Date: Thu, 21 Aug 2014 14:25:22 +0100 Message-ID: <20140821132522.GI4266@lee--X1> References: <20140821113046.GZ4266@lee--X1> <20140821135707.GA16867@awelinux> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-ie0-f176.google.com ([209.85.223.176]:36370 "EHLO mail-ie0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754574AbaHUNZ3 (ORCPT ); Thu, 21 Aug 2014 09:25:29 -0400 Received: by mail-ie0-f176.google.com with SMTP id tr6so4468537ieb.7 for ; Thu, 21 Aug 2014 06:25:28 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140821135707.GA16867@awelinux> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Andreas Werner Cc: linux-kernel@vger.kernel.org, sameo@linux.intel.com, wim@iguana.be, linux-watchdog@vger.kernel.org, cooloney@gmail.com, rpurdie@rpsys.net, linux-leds@vger.kernel.org, jdelvare@suse.de, linux@roeck-us.net, lm-sensors@lm-sensors.org On Thu, 21 Aug 2014, Andreas Werner wrote: > On Thu, Aug 21, 2014 at 12:30:46PM +0100, Lee Jones wrote: > > On Wed, 13 Aug 2014, Andreas Werner wrote: > > > The MEN 14F021P00 Board Management Controller provides an > > > I2C interface to the host to access the feature implemented in th= e BMC. > > > The BMC is a PIC Microntroller assembled on CPCI Card from MEN Mi= kroelektronik > > > and on a few Box/Display Computer. > > >=20 > > > Added MFD Core driver, supporting the I2C communication to the de= vice. > > >=20 > > > The MFD driver currently supports the following features: > > > - Watchdog > > > - LEDs > > > - Hwmon (voltage monitoring) > > >=20 > > > Signed-off-by: Andreas Werner > > > --- > > > drivers/mfd/Kconfig | 12 +++++ > > > drivers/mfd/Makefile | 1 + > > > drivers/mfd/menf21bmc.c | 132 ++++++++++++++++++++++++++++++++++= ++++++++++++++ > > > 3 files changed, 145 insertions(+) > > > create mode 100644 drivers/mfd/menf21bmc.c > > >=20 > > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > > index b8d9ca0..bf155b9 100644 > > > --- a/drivers/mfd/Kconfig > > > +++ b/drivers/mfd/Kconfig > > > @@ -453,6 +453,18 @@ config MFD_MAX8998 > > > additional drivers must be enabled in order to use the functi= onality > > > of the device. > > > =20 > > > +config MFD_MENF21BMC > > > + tristate "MEN 14F021P00 Board Management Controller Support" > > > + depends on I2C=3Dy > >=20 > > Why must I2C be built-in? >=20 > Sorry my mistake, I2C must not be built in. >=20 > >=20 > > > + select MFD_CORE > > > + help > > > + Say yes here to add support for the MEN 14F021P00 BMC > > > + which is a Board Management Controller connected to the I2C b= us. > > > + The device supports multiple sub-devices like LED, HWMON and= WDT. > > > + This driver provides common support for accessing the devices= ; > > > + additional drivers must be enabled in order to use the > > > + functionality of the BMC device. > > > + > >=20 > > Apart from that the patch looks good to me. > >=20 > > I'm assuming this can go in via the MFD tree by itself? >=20 > Yes why not. > Do you want to have a single patch for the MFD or > is it better to wait for the other Subsystem maintainer that I=20 > can resend a patch v5? When you resent, apply my Ack and I'll pick it up when the other Maintainers are happy. > >=20 > > Acked-by: Lee Jones > >=20 --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ie0-f170.google.com ([209.85.223.170]:59582 "EHLO mail-ie0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754493AbaHUNZ3 (ORCPT ); Thu, 21 Aug 2014 09:25:29 -0400 Received: by mail-ie0-f170.google.com with SMTP id rl12so4704861iec.1 for ; Thu, 21 Aug 2014 06:25:28 -0700 (PDT) Date: Thu, 21 Aug 2014 14:25:22 +0100 From: Lee Jones To: Andreas Werner Cc: linux-kernel@vger.kernel.org, sameo@linux.intel.com, wim@iguana.be, linux-watchdog@vger.kernel.org, cooloney@gmail.com, rpurdie@rpsys.net, linux-leds@vger.kernel.org, jdelvare@suse.de, linux@roeck-us.net, lm-sensors@lm-sensors.org Subject: Re: [PATCH v4 1/4] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver Message-ID: <20140821132522.GI4266@lee--X1> References: <20140821113046.GZ4266@lee--X1> <20140821135707.GA16867@awelinux> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: QUOTED-PRINTABLE In-Reply-To: <20140821135707.GA16867@awelinux> Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On Thu, 21 Aug 2014, Andreas Werner wrote: > On Thu, Aug 21, 2014 at 12:30:46PM +0100, Lee Jones wrote: > > On Wed, 13 Aug 2014, Andreas Werner wrote: > > > The MEN 14F021P00 Board Management Controller provides an > > > I2C interface to the host to access the feature implemented in th= e BMC. > > > The BMC is a PIC Microntroller assembled on CPCI Card from MEN Mi= kroelektronik > > > and on a few Box/Display Computer. > > >=20 > > > Added MFD Core driver, supporting the I2C communication to the de= vice. > > >=20 > > > The MFD driver currently supports the following features: > > > - Watchdog > > > - LEDs > > > - Hwmon (voltage monitoring) > > >=20 > > > Signed-off-by: Andreas Werner > > > --- > > > drivers/mfd/Kconfig | 12 +++++ > > > drivers/mfd/Makefile | 1 + > > > drivers/mfd/menf21bmc.c | 132 ++++++++++++++++++++++++++++++++++= ++++++++++++++ > > > 3 files changed, 145 insertions(+) > > > create mode 100644 drivers/mfd/menf21bmc.c > > >=20 > > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > > index b8d9ca0..bf155b9 100644 > > > --- a/drivers/mfd/Kconfig > > > +++ b/drivers/mfd/Kconfig > > > @@ -453,6 +453,18 @@ config MFD_MAX8998 > > > additional drivers must be enabled in order to use the functi= onality > > > of the device. > > > =20 > > > +config MFD_MENF21BMC > > > + tristate "MEN 14F021P00 Board Management Controller Support" > > > + depends on I2C=3Dy > >=20 > > Why must I2C be built-in? >=20 > Sorry my mistake, I2C must not be built in. >=20 > >=20 > > > + select MFD_CORE > > > + help > > > + Say yes here to add support for the MEN 14F021P00 BMC > > > + which is a Board Management Controller connected to the I2C b= us. > > > + The device supports multiple sub-devices like LED, HWMON and= WDT. > > > + This driver provides common support for accessing the devices= ; > > > + additional drivers must be enabled in order to use the > > > + functionality of the BMC device. > > > + > >=20 > > Apart from that the patch looks good to me. > >=20 > > I'm assuming this can go in via the MFD tree by itself? >=20 > Yes why not. > Do you want to have a single patch for the MFD or > is it better to wait for the other Subsystem maintainer that I=20 > can resend a patch v5? When you resent, apply my Ack and I'll pick it up when the other Maintainers are happy. > >=20 > > Acked-by: Lee Jones > >=20 --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-watchdo= g" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Thu, 21 Aug 2014 13:25:22 +0000 Subject: Re: [lm-sensors] [PATCH v4 1/4] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver Message-Id: <20140821132522.GI4266@lee--X1> List-Id: References: <20140821113046.GZ4266@lee--X1> <20140821135707.GA16867@awelinux> In-Reply-To: <20140821135707.GA16867@awelinux> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andreas Werner Cc: linux-kernel@vger.kernel.org, sameo@linux.intel.com, wim@iguana.be, linux-watchdog@vger.kernel.org, cooloney@gmail.com, rpurdie@rpsys.net, linux-leds@vger.kernel.org, jdelvare@suse.de, linux@roeck-us.net, lm-sensors@lm-sensors.org T24gVGh1LCAyMSBBdWcgMjAxNCwgQW5kcmVhcyBXZXJuZXIgd3JvdGU6Cj4gT24gVGh1LCBBdWcg MjEsIDIwMTQgYXQgMTI6MzA6NDZQTSArMDEwMCwgTGVlIEpvbmVzIHdyb3RlOgo+ID4gT24gV2Vk LCAxMyBBdWcgMjAxNCwgQW5kcmVhcyBXZXJuZXIgd3JvdGU6Cj4gPiA+IFRoZSBNRU4gMTRGMDIx UDAwIEJvYXJkIE1hbmFnZW1lbnQgQ29udHJvbGxlciBwcm92aWRlcyBhbgo+ID4gPiBJMkMgaW50 ZXJmYWNlIHRvIHRoZSBob3N0IHRvIGFjY2VzcyB0aGUgZmVhdHVyZSBpbXBsZW1lbnRlZCBpbiB0 aGUgQk1DLgo+ID4gPiBUaGUgQk1DIGlzIGEgUElDIE1pY3JvbnRyb2xsZXIgYXNzZW1ibGVkIG9u IENQQ0kgQ2FyZCBmcm9tIE1FTiBNaWtyb2VsZWt0cm9uaWsKPiA+ID4gYW5kIG9uIGEgZmV3IEJv eC9EaXNwbGF5IENvbXB1dGVyLgo+ID4gPiAKPiA+ID4gQWRkZWQgTUZEIENvcmUgZHJpdmVyLCBz dXBwb3J0aW5nIHRoZSBJMkMgY29tbXVuaWNhdGlvbiB0byB0aGUgZGV2aWNlLgo+ID4gPiAKPiA+ ID4gVGhlIE1GRCBkcml2ZXIgY3VycmVudGx5IHN1cHBvcnRzIHRoZSBmb2xsb3dpbmcgZmVhdHVy ZXM6Cj4gPiA+ICAJLSBXYXRjaGRvZwo+ID4gPiAgCS0gTEVEcwo+ID4gPiAJLSBId21vbiAodm9s dGFnZSBtb25pdG9yaW5nKQo+ID4gPiAKPiA+ID4gU2lnbmVkLW9mZi1ieTogQW5kcmVhcyBXZXJu ZXIgPGFuZHJlYXMud2VybmVyQG1lbi5kZT4KPiA+ID4gLS0tCj4gPiA+ICBkcml2ZXJzL21mZC9L Y29uZmlnICAgICB8ICAxMiArKysrKwo+ID4gPiAgZHJpdmVycy9tZmQvTWFrZWZpbGUgICAgfCAg IDEgKwo+ID4gPiAgZHJpdmVycy9tZmQvbWVuZjIxYm1jLmMgfCAxMzIgKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gPiA+ICAzIGZpbGVzIGNoYW5nZWQs IDE0NSBpbnNlcnRpb25zKCspCj4gPiA+ICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9tZmQv bWVuZjIxYm1jLmMKPiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21mZC9LY29uZmln IGIvZHJpdmVycy9tZmQvS2NvbmZpZwo+ID4gPiBpbmRleCBiOGQ5Y2EwLi5iZjE1NWI5IDEwMDY0 NAo+ID4gPiAtLS0gYS9kcml2ZXJzL21mZC9LY29uZmlnCj4gPiA+ICsrKyBiL2RyaXZlcnMvbWZk L0tjb25maWcKPiA+ID4gQEAgLTQ1Myw2ICs0NTMsMTggQEAgY29uZmlnIE1GRF9NQVg4OTk4Cj4g PiA+ICAJICBhZGRpdGlvbmFsIGRyaXZlcnMgbXVzdCBiZSBlbmFibGVkIGluIG9yZGVyIHRvIHVz ZSB0aGUgZnVuY3Rpb25hbGl0eQo+ID4gPiAgCSAgb2YgdGhlIGRldmljZS4KPiA+ID4gIAo+ID4g PiArY29uZmlnIE1GRF9NRU5GMjFCTUMKPiA+ID4gKwl0cmlzdGF0ZSAiTUVOIDE0RjAyMVAwMCBC b2FyZCBNYW5hZ2VtZW50IENvbnRyb2xsZXIgU3VwcG9ydCIKPiA+ID4gKwlkZXBlbmRzIG9uIEky Qz15Cj4gPiAKPiA+IFdoeSBtdXN0IEkyQyBiZSBidWlsdC1pbj8KPiAKPiBTb3JyeSBteSBtaXN0 YWtlLCBJMkMgbXVzdCBub3QgYmUgYnVpbHQgaW4uCj4gCj4gPiAKPiA+ID4gKwlzZWxlY3QgTUZE X0NPUkUKPiA+ID4gKwloZWxwCj4gPiA+ICsJICBTYXkgeWVzIGhlcmUgdG8gYWRkIHN1cHBvcnQg Zm9yIHRoZSBNRU4gMTRGMDIxUDAwIEJNQwo+ID4gPiArCSAgd2hpY2ggaXMgYSBCb2FyZCBNYW5h Z2VtZW50IENvbnRyb2xsZXIgY29ubmVjdGVkIHRvIHRoZSBJMkMgYnVzLgo+ID4gPiArCSAgVGhl IGRldmljZSBzdXBwb3J0cyBtdWx0aXBsZSBzdWItZGV2aWNlcyBsaWtlIExFRCwgSFdNT04gIGFu ZCBXRFQuCj4gPiA+ICsJICBUaGlzIGRyaXZlciBwcm92aWRlcyBjb21tb24gc3VwcG9ydCBmb3Ig YWNjZXNzaW5nIHRoZSBkZXZpY2VzOwo+ID4gPiArCSAgYWRkaXRpb25hbCBkcml2ZXJzIG11c3Qg YmUgZW5hYmxlZCBpbiBvcmRlciB0byB1c2UgdGhlCj4gPiA+ICsJICBmdW5jdGlvbmFsaXR5IG9m IHRoZSBCTUMgZGV2aWNlLgo+ID4gPiArCj4gPiAKPiA+IEFwYXJ0IGZyb20gdGhhdCB0aGUgcGF0 Y2ggbG9va3MgZ29vZCB0byBtZS4KPiA+IAo+ID4gSSdtIGFzc3VtaW5nIHRoaXMgY2FuIGdvIGlu IHZpYSB0aGUgTUZEIHRyZWUgYnkgaXRzZWxmPwo+IAo+IFllcyB3aHkgbm90Lgo+IERvIHlvdSB3 YW50IHRvIGhhdmUgYSBzaW5nbGUgcGF0Y2ggZm9yIHRoZSBNRkQgb3IKPiBpcyBpdCBiZXR0ZXIg dG8gd2FpdCBmb3IgdGhlIG90aGVyIFN1YnN5c3RlbSBtYWludGFpbmVyIHRoYXQgSSAKPiBjYW4g cmVzZW5kIGEgcGF0Y2ggdjU/CgpXaGVuIHlvdSByZXNlbnQsIGFwcGx5IG15IEFjayBhbmQgSSds bCBwaWNrIGl0IHVwIHdoZW4gdGhlIG90aGVyCk1haW50YWluZXJzIGFyZSBoYXBweS4KCj4gPiAK PiA+IEFja2VkLWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgo+ID4gCgotLSAK TGVlIEpvbmVzCkxpbmFybyBTVE1pY3JvZWxlY3Ryb25pY3MgTGFuZGluZyBUZWFtIExlYWQKTGlu YXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFSTSBTb0NzCkZvbGxvdyBMaW5h cm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxtLXNlbnNvcnMgbWFpbGluZyBsaXN0CmxtLXNlbnNvcnNA bG0tc2Vuc29ycy5vcmcKaHR0cDovL2xpc3RzLmxtLXNlbnNvcnMub3JnL21haWxtYW4vbGlzdGlu Zm8vbG0tc2Vuc29ycw=