From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Werner Subject: Re: [PATCH v4 1/4] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver Date: Thu, 21 Aug 2014 15:57:08 +0200 Message-ID: <20140821135707.GA16867@awelinux> References: <20140821113046.GZ4266@lee--X1> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail1.bemta3.messagelabs.com ([195.245.230.177]:27038 "EHLO mail1.bemta3.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754229AbaHUNIr (ORCPT ); Thu, 21 Aug 2014 09:08:47 -0400 Content-Disposition: inline In-Reply-To: <20140821113046.GZ4266@lee--X1> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Lee Jones Cc: Andreas Werner , linux-kernel@vger.kernel.org, sameo@linux.intel.com, wim@iguana.be, linux-watchdog@vger.kernel.org, cooloney@gmail.com, rpurdie@rpsys.net, linux-leds@vger.kernel.org, jdelvare@suse.de, linux@roeck-us.net, lm-sensors@lm-sensors.org On Thu, Aug 21, 2014 at 12:30:46PM +0100, Lee Jones wrote: > On Wed, 13 Aug 2014, Andreas Werner wrote: > > The MEN 14F021P00 Board Management Controller provides an > > I2C interface to the host to access the feature implemented in the = BMC. > > The BMC is a PIC Microntroller assembled on CPCI Card from MEN Mikr= oelektronik > > and on a few Box/Display Computer. > >=20 > > Added MFD Core driver, supporting the I2C communication to the devi= ce. > >=20 > > The MFD driver currently supports the following features: > > - Watchdog > > - LEDs > > - Hwmon (voltage monitoring) > >=20 > > Signed-off-by: Andreas Werner > > --- > > drivers/mfd/Kconfig | 12 +++++ > > drivers/mfd/Makefile | 1 + > > drivers/mfd/menf21bmc.c | 132 ++++++++++++++++++++++++++++++++++++= ++++++++++++ > > 3 files changed, 145 insertions(+) > > create mode 100644 drivers/mfd/menf21bmc.c > >=20 > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > index b8d9ca0..bf155b9 100644 > > --- a/drivers/mfd/Kconfig > > +++ b/drivers/mfd/Kconfig > > @@ -453,6 +453,18 @@ config MFD_MAX8998 > > additional drivers must be enabled in order to use the function= ality > > of the device. > > =20 > > +config MFD_MENF21BMC > > + tristate "MEN 14F021P00 Board Management Controller Support" > > + depends on I2C=3Dy >=20 > Why must I2C be built-in? Sorry my mistake, I2C must not be built in. >=20 > > + select MFD_CORE > > + help > > + Say yes here to add support for the MEN 14F021P00 BMC > > + which is a Board Management Controller connected to the I2C bus= =2E > > + The device supports multiple sub-devices like LED, HWMON and W= DT. > > + This driver provides common support for accessing the devices; > > + additional drivers must be enabled in order to use the > > + functionality of the BMC device. > > + >=20 > Apart from that the patch looks good to me. >=20 > I'm assuming this can go in via the MFD tree by itself? Yes why not. Do you want to have a single patch for the MFD or is it better to wait for the other Subsystem maintainer that I=20 can resend a patch v5? Regards Andy >=20 > Acked-by: Lee Jones >=20 > --=20 > Lee Jones > Linaro STMicroelectronics Landing Team Lead > Linaro.org =E2=94=82 Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail1.bemta3.messagelabs.com ([195.245.230.177]:27038 "EHLO mail1.bemta3.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754229AbaHUNIr (ORCPT ); Thu, 21 Aug 2014 09:08:47 -0400 Date: Thu, 21 Aug 2014 15:57:08 +0200 From: Andreas Werner To: Lee Jones CC: Andreas Werner , , , , , , , , , , Subject: Re: [PATCH v4 1/4] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver Message-ID: <20140821135707.GA16867@awelinux> References: <20140821113046.GZ4266@lee--X1> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: QUOTED-PRINTABLE In-Reply-To: <20140821113046.GZ4266@lee--X1> Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On Thu, Aug 21, 2014 at 12:30:46PM +0100, Lee Jones wrote: > On Wed, 13 Aug 2014, Andreas Werner wrote: > > The MEN 14F021P00 Board Management Controller provides an > > I2C interface to the host to access the feature implemented in the = BMC. > > The BMC is a PIC Microntroller assembled on CPCI Card from MEN Mikr= oelektronik > > and on a few Box/Display Computer. > >=20 > > Added MFD Core driver, supporting the I2C communication to the devi= ce. > >=20 > > The MFD driver currently supports the following features: > > - Watchdog > > - LEDs > > - Hwmon (voltage monitoring) > >=20 > > Signed-off-by: Andreas Werner > > --- > > drivers/mfd/Kconfig | 12 +++++ > > drivers/mfd/Makefile | 1 + > > drivers/mfd/menf21bmc.c | 132 ++++++++++++++++++++++++++++++++++++= ++++++++++++ > > 3 files changed, 145 insertions(+) > > create mode 100644 drivers/mfd/menf21bmc.c > >=20 > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > index b8d9ca0..bf155b9 100644 > > --- a/drivers/mfd/Kconfig > > +++ b/drivers/mfd/Kconfig > > @@ -453,6 +453,18 @@ config MFD_MAX8998 > > additional drivers must be enabled in order to use the function= ality > > of the device. > > =20 > > +config MFD_MENF21BMC > > + tristate "MEN 14F021P00 Board Management Controller Support" > > + depends on I2C=3Dy >=20 > Why must I2C be built-in? Sorry my mistake, I2C must not be built in. >=20 > > + select MFD_CORE > > + help > > + Say yes here to add support for the MEN 14F021P00 BMC > > + which is a Board Management Controller connected to the I2C bus= =2E > > + The device supports multiple sub-devices like LED, HWMON and W= DT. > > + This driver provides common support for accessing the devices; > > + additional drivers must be enabled in order to use the > > + functionality of the BMC device. > > + >=20 > Apart from that the patch looks good to me. >=20 > I'm assuming this can go in via the MFD tree by itself? Yes why not. Do you want to have a single patch for the MFD or is it better to wait for the other Subsystem maintainer that I=20 can resend a patch v5? Regards Andy >=20 > Acked-by: Lee Jones >=20 > --=20 > Lee Jones > Linaro STMicroelectronics Landing Team Lead > Linaro.org =E2=94=82 Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-watchdo= g" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Werner Date: Thu, 21 Aug 2014 13:57:08 +0000 Subject: Re: [lm-sensors] [PATCH v4 1/4] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver Message-Id: <20140821135707.GA16867@awelinux> List-Id: References: <20140821113046.GZ4266@lee--X1> In-Reply-To: <20140821113046.GZ4266@lee--X1> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Lee Jones Cc: Andreas Werner , linux-kernel@vger.kernel.org, sameo@linux.intel.com, wim@iguana.be, linux-watchdog@vger.kernel.org, cooloney@gmail.com, rpurdie@rpsys.net, linux-leds@vger.kernel.org, jdelvare@suse.de, linux@roeck-us.net, lm-sensors@lm-sensors.org T24gVGh1LCBBdWcgMjEsIDIwMTQgYXQgMTI6MzA6NDZQTSArMDEwMCwgTGVlIEpvbmVzIHdyb3Rl Ogo+IE9uIFdlZCwgMTMgQXVnIDIwMTQsIEFuZHJlYXMgV2VybmVyIHdyb3RlOgo+ID4gVGhlIE1F TiAxNEYwMjFQMDAgQm9hcmQgTWFuYWdlbWVudCBDb250cm9sbGVyIHByb3ZpZGVzIGFuCj4gPiBJ MkMgaW50ZXJmYWNlIHRvIHRoZSBob3N0IHRvIGFjY2VzcyB0aGUgZmVhdHVyZSBpbXBsZW1lbnRl ZCBpbiB0aGUgQk1DLgo+ID4gVGhlIEJNQyBpcyBhIFBJQyBNaWNyb250cm9sbGVyIGFzc2VtYmxl ZCBvbiBDUENJIENhcmQgZnJvbSBNRU4gTWlrcm9lbGVrdHJvbmlrCj4gPiBhbmQgb24gYSBmZXcg Qm94L0Rpc3BsYXkgQ29tcHV0ZXIuCj4gPiAKPiA+IEFkZGVkIE1GRCBDb3JlIGRyaXZlciwgc3Vw cG9ydGluZyB0aGUgSTJDIGNvbW11bmljYXRpb24gdG8gdGhlIGRldmljZS4KPiA+IAo+ID4gVGhl IE1GRCBkcml2ZXIgY3VycmVudGx5IHN1cHBvcnRzIHRoZSBmb2xsb3dpbmcgZmVhdHVyZXM6Cj4g PiAgCS0gV2F0Y2hkb2cKPiA+ICAJLSBMRURzCj4gPiAJLSBId21vbiAodm9sdGFnZSBtb25pdG9y aW5nKQo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBBbmRyZWFzIFdlcm5lciA8YW5kcmVhcy53ZXJu ZXJAbWVuLmRlPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9tZmQvS2NvbmZpZyAgICAgfCAgMTIgKysr KysKPiA+ICBkcml2ZXJzL21mZC9NYWtlZmlsZSAgICB8ICAgMSArCj4gPiAgZHJpdmVycy9tZmQv bWVuZjIxYm1jLmMgfCAxMzIgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrCj4gPiAgMyBmaWxlcyBjaGFuZ2VkLCAxNDUgaW5zZXJ0aW9ucygrKQo+ID4gIGNy ZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL21mZC9tZW5mMjFibWMuYwo+ID4gCj4gPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9tZmQvS2NvbmZpZyBiL2RyaXZlcnMvbWZkL0tjb25maWcKPiA+IGluZGV4 IGI4ZDljYTAuLmJmMTU1YjkgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL21mZC9LY29uZmlnCj4g PiArKysgYi9kcml2ZXJzL21mZC9LY29uZmlnCj4gPiBAQCAtNDUzLDYgKzQ1MywxOCBAQCBjb25m aWcgTUZEX01BWDg5OTgKPiA+ICAJICBhZGRpdGlvbmFsIGRyaXZlcnMgbXVzdCBiZSBlbmFibGVk IGluIG9yZGVyIHRvIHVzZSB0aGUgZnVuY3Rpb25hbGl0eQo+ID4gIAkgIG9mIHRoZSBkZXZpY2Uu Cj4gPiAgCj4gPiArY29uZmlnIE1GRF9NRU5GMjFCTUMKPiA+ICsJdHJpc3RhdGUgIk1FTiAxNEYw MjFQMDAgQm9hcmQgTWFuYWdlbWVudCBDb250cm9sbGVyIFN1cHBvcnQiCj4gPiArCWRlcGVuZHMg b24gSTJDPXkKPiAKPiBXaHkgbXVzdCBJMkMgYmUgYnVpbHQtaW4/CgpTb3JyeSBteSBtaXN0YWtl LCBJMkMgbXVzdCBub3QgYmUgYnVpbHQgaW4uCgo+IAo+ID4gKwlzZWxlY3QgTUZEX0NPUkUKPiA+ ICsJaGVscAo+ID4gKwkgIFNheSB5ZXMgaGVyZSB0byBhZGQgc3VwcG9ydCBmb3IgdGhlIE1FTiAx NEYwMjFQMDAgQk1DCj4gPiArCSAgd2hpY2ggaXMgYSBCb2FyZCBNYW5hZ2VtZW50IENvbnRyb2xs ZXIgY29ubmVjdGVkIHRvIHRoZSBJMkMgYnVzLgo+ID4gKwkgIFRoZSBkZXZpY2Ugc3VwcG9ydHMg bXVsdGlwbGUgc3ViLWRldmljZXMgbGlrZSBMRUQsIEhXTU9OICBhbmQgV0RULgo+ID4gKwkgIFRo aXMgZHJpdmVyIHByb3ZpZGVzIGNvbW1vbiBzdXBwb3J0IGZvciBhY2Nlc3NpbmcgdGhlIGRldmlj ZXM7Cj4gPiArCSAgYWRkaXRpb25hbCBkcml2ZXJzIG11c3QgYmUgZW5hYmxlZCBpbiBvcmRlciB0 byB1c2UgdGhlCj4gPiArCSAgZnVuY3Rpb25hbGl0eSBvZiB0aGUgQk1DIGRldmljZS4KPiA+ICsK PiAKPiBBcGFydCBmcm9tIHRoYXQgdGhlIHBhdGNoIGxvb2tzIGdvb2QgdG8gbWUuCj4gCj4gSSdt IGFzc3VtaW5nIHRoaXMgY2FuIGdvIGluIHZpYSB0aGUgTUZEIHRyZWUgYnkgaXRzZWxmPwoKWWVz IHdoeSBub3QuCkRvIHlvdSB3YW50IHRvIGhhdmUgYSBzaW5nbGUgcGF0Y2ggZm9yIHRoZSBNRkQg b3IKaXMgaXQgYmV0dGVyIHRvIHdhaXQgZm9yIHRoZSBvdGhlciBTdWJzeXN0ZW0gbWFpbnRhaW5l ciB0aGF0IEkgCmNhbiByZXNlbmQgYSBwYXRjaCB2NT8KCgpSZWdhcmRzCkFuZHkKCj4gCj4gQWNr ZWQtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+Cj4gCj4gLS0gCj4gTGVlIEpv bmVzCj4gTGluYXJvIFNUTWljcm9lbGVjdHJvbmljcyBMYW5kaW5nIFRlYW0gTGVhZAo+IExpbmFy by5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBUk0gU29Dcwo+IEZvbGxvdyBMaW5h cm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxtLXNlbnNvcnMgbWFpbGluZyBsaXN0CmxtLXNlbnNvcnNA bG0tc2Vuc29ycy5vcmcKaHR0cDovL2xpc3RzLmxtLXNlbnNvcnMub3JnL21haWxtYW4vbGlzdGlu Zm8vbG0tc2Vuc29ycw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755228AbaHUNIt (ORCPT ); Thu, 21 Aug 2014 09:08:49 -0400 Received: from mail1.bemta3.messagelabs.com ([195.245.230.177]:27038 "EHLO mail1.bemta3.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754229AbaHUNIr (ORCPT ); Thu, 21 Aug 2014 09:08:47 -0400 X-Env-Sender: Andreas.Werner@men.de X-Msg-Ref: server-2.tower-38.messagelabs.com!1408626275!27367732!1 X-Originating-IP: [80.255.6.145] X-StarScan-Received: X-StarScan-Version: 6.11.3; banners=-,-,- X-VirusChecked: Checked X-PGP-Universal: processed; by keys.men.de on Thu, 21 Aug 2014 15:04:37 +0200 Date: Thu, 21 Aug 2014 15:57:08 +0200 From: Andreas Werner To: Lee Jones CC: Andreas Werner , , , , , , , , , , Subject: Re: [PATCH v4 1/4] drivers/mfd/menf21bmc: introduce MEN 14F021P00 BMC MFD Core driver Message-ID: <20140821135707.GA16867@awelinux> References: <20140821113046.GZ4266@lee--X1> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140821113046.GZ4266@lee--X1> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [192.1.1.171] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 21, 2014 at 12:30:46PM +0100, Lee Jones wrote: > On Wed, 13 Aug 2014, Andreas Werner wrote: > > The MEN 14F021P00 Board Management Controller provides an > > I2C interface to the host to access the feature implemented in the BMC. > > The BMC is a PIC Microntroller assembled on CPCI Card from MEN Mikroelektronik > > and on a few Box/Display Computer. > > > > Added MFD Core driver, supporting the I2C communication to the device. > > > > The MFD driver currently supports the following features: > > - Watchdog > > - LEDs > > - Hwmon (voltage monitoring) > > > > Signed-off-by: Andreas Werner > > --- > > drivers/mfd/Kconfig | 12 +++++ > > drivers/mfd/Makefile | 1 + > > drivers/mfd/menf21bmc.c | 132 ++++++++++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 145 insertions(+) > > create mode 100644 drivers/mfd/menf21bmc.c > > > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > index b8d9ca0..bf155b9 100644 > > --- a/drivers/mfd/Kconfig > > +++ b/drivers/mfd/Kconfig > > @@ -453,6 +453,18 @@ config MFD_MAX8998 > > additional drivers must be enabled in order to use the functionality > > of the device. > > > > +config MFD_MENF21BMC > > + tristate "MEN 14F021P00 Board Management Controller Support" > > + depends on I2C=y > > Why must I2C be built-in? Sorry my mistake, I2C must not be built in. > > > + select MFD_CORE > > + help > > + Say yes here to add support for the MEN 14F021P00 BMC > > + which is a Board Management Controller connected to the I2C bus. > > + The device supports multiple sub-devices like LED, HWMON and WDT. > > + This driver provides common support for accessing the devices; > > + additional drivers must be enabled in order to use the > > + functionality of the BMC device. > > + > > Apart from that the patch looks good to me. > > I'm assuming this can go in via the MFD tree by itself? Yes why not. Do you want to have a single patch for the MFD or is it better to wait for the other Subsystem maintainer that I can resend a patch v5? Regards Andy > > Acked-by: Lee Jones > > -- > Lee Jones > Linaro STMicroelectronics Landing Team Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog