All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH] usb: phy: twl4030-usb: Fix regressions to runtime PM on omaps
Date: Thu, 21 Aug 2014 10:21:08 -0700	[thread overview]
Message-ID: <20140821172108.GC10066@atomide.com> (raw)
In-Reply-To: <20140821170615.GG11146@saruman.home>

* Felipe Balbi <balbi@ti.com> [140821 10:09]:
> On Thu, Aug 21, 2014 at 09:43:46AM -0700, Tony Lindgren wrote:
> > @@ -744,6 +778,9 @@ static int twl4030_usb_probe(struct platform_device *pdev)
> >  		return status;
> >  	}
> >  
> > +	pm_runtime_mark_last_busy(&pdev->dev);
> > +	pm_runtime_put(&pdev->dev);
> 
> don't you wanna do a put_autosuspend() here instead ?

Sure yeah makes sense as the twl4030_phy_init() usually
runs shortly after.
 
> Other than that
> 
> Acked-by: Felipe Balbi <balbi@ti.com>

Thanks,

Tony

  reply	other threads:[~2014-08-21 17:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-21 16:43 [PATCH] usb: phy: twl4030-usb: Fix regressions to runtime PM on omaps Tony Lindgren
2014-08-21 17:06 ` Felipe Balbi
2014-08-21 17:06   ` Felipe Balbi
2014-08-21 17:21   ` Tony Lindgren [this message]
     [not found] ` <20140821164346.GA10066-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2014-08-22  4:48   ` Kishon Vijay Abraham I
2014-08-22  4:48     ` Kishon Vijay Abraham I
2014-08-22 16:51     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140821172108.GC10066@atomide.com \
    --to=tony@atomide.com \
    --cc=balbi@ti.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.