From: Damien Lespiau <damien.lespiau@intel.com>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH 2/3] drm/i915: rename gen8_init_clock_gating to broadwell_init_clock_gating
Date: Thu, 21 Aug 2014 22:45:06 +0100 [thread overview]
Message-ID: <20140821214506.GB29975@strange.ger.corp.intel.com> (raw)
In-Reply-To: <1408651778-2636-2-git-send-email-przanoni@gmail.com>
On Thu, Aug 21, 2014 at 05:09:37PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> Because CHV uses cherryview_init_clock_gating instead of
> gen8_init_clock_gating.
>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
--
Damien
> ---
> drivers/gpu/drm/i915/intel_pm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> I really wish we were using the three-letter-acronyms instead of the full names
> on the functions. If I send another patch renaming everything, will anybody
> complain?
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index b3e948f..35495fc 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -5502,7 +5502,7 @@ static void lpt_suspend_hw(struct drm_device *dev)
> }
> }
>
> -static void gen8_init_clock_gating(struct drm_device *dev)
> +static void broadwell_init_clock_gating(struct drm_device *dev)
> {
> struct drm_i915_private *dev_priv = dev->dev_private;
> enum pipe pipe;
> @@ -7251,7 +7251,7 @@ void intel_init_pm(struct drm_device *dev)
> else if (IS_HASWELL(dev))
> dev_priv->display.init_clock_gating = haswell_init_clock_gating;
> else if (INTEL_INFO(dev)->gen == 8)
> - dev_priv->display.init_clock_gating = gen8_init_clock_gating;
> + dev_priv->display.init_clock_gating = broadwell_init_clock_gating;
> } else if (IS_CHERRYVIEW(dev)) {
> dev_priv->display.update_wm = cherryview_update_wm;
> dev_priv->display.update_sprite_wm = valleyview_update_sprite_wm;
> --
> 2.0.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-08-21 21:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 20:09 [PATCH 1/3] drm/i915: call lpt_init_clock_gating on BDW too Paulo Zanoni
2014-08-21 20:09 ` [PATCH 2/3] drm/i915: rename gen8_init_clock_gating to broadwell_init_clock_gating Paulo Zanoni
2014-08-21 21:45 ` Damien Lespiau [this message]
2014-08-21 20:09 ` [PATCH 3/3] drm/i915: send PCI_D3hot adapter opregion message on BDW RPM suspend Paulo Zanoni
2014-08-21 21:47 ` Damien Lespiau
2014-08-26 21:06 ` Daniel Vetter
2014-08-21 21:41 ` [PATCH 1/3] drm/i915: call lpt_init_clock_gating on BDW too Damien Lespiau
2014-08-21 21:50 ` Damien Lespiau
2014-08-26 17:16 ` Daniel Vetter
2014-08-26 17:24 ` Damien Lespiau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140821214506.GB29975@strange.ger.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.