From: Christoph Hellwig <hch@infradead.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Christoph Hellwig <hch@infradead.org>,
Douglas Gilbert <dgilbert@interlog.com>,
Tiziano Bacocco <tiziano.bacocco@gmail.com>,
bugzilla-daemon@bugzilla.kernel.org,
SCSI development list <linux-scsi@vger.kernel.org>,
USB list <linux-usb@vger.kernel.org>
Subject: Re: [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN
Date: Thu, 21 Aug 2014 14:57:44 -0700 [thread overview]
Message-ID: <20140821215744.GA29651@infradead.org> (raw)
In-Reply-To: <yq1bnrdr01e.fsf@sermon.lab.mkp.net>
On Thu, Aug 21, 2014 at 05:43:41PM -0400, Martin K. Petersen wrote:
> Alan> Okay, here's a patch that implements the suggestion, except that I
> Alan> put the flag in the Scsi_Host structure instead of the template.
> Alan> This was to minimize the impact of the change. Among the various
> Alan> SCSI-over-USB transports, only the Bulk-Only transport gives the
> Alan> LUN separately from the CDB. I don't know if there are any
> Alan> multi-LUN USB devices that don't use the Bulk-Only transport, but
> Alan> if there are then they won't work if the LUN isn't stored in
> Alan> CDB[1].
>
> I'm in agreement with this approach.
I like it too. One idea to unclutter the fastpath would be to have a
single flag that controls if the LUN is set which is based on the
host(-template) flag and the scsi level, which would allow us to remove
all the clutter around that area.
next prev parent reply other threads:[~2014-08-21 21:57 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-20 0:37 [Bug 80711] New: SG_FLAG_LUN_INHIBIT is no longer implemented and there's not way to prevent the kernel from using the 2nd cdb byte for the LUN bugzilla-daemon
2014-07-20 14:13 ` [Bug 80711] " bugzilla-daemon
2014-07-21 9:05 ` bugzilla-daemon
2014-07-22 16:13 ` Christoph Hellwig
2014-07-29 15:57 ` [Bug 80711] [PATCH]SG_FLAG_LUN_INHIBIT " bugzilla-daemon
2014-08-06 13:29 ` Douglas Gilbert
2014-08-06 19:32 ` Christoph Hellwig
2014-08-06 20:02 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1408061545030.1145-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2014-08-06 20:25 ` Alan Stern
2014-08-07 6:39 ` Christoph Hellwig
2014-08-07 15:58 ` Alan Stern
2014-08-19 17:56 ` Christoph Hellwig
2014-08-20 19:15 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1408201507280.1959-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2014-08-21 14:41 ` Douglas Gilbert
2014-08-21 14:42 ` Christoph Hellwig
2014-08-21 17:31 ` Alan Stern
2014-08-21 21:43 ` Martin K. Petersen
2014-08-21 21:57 ` Christoph Hellwig [this message]
[not found] ` <20140821215744.GA29651-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2014-08-22 14:53 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1408221044450.967-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2014-08-22 15:05 ` Christoph Hellwig
[not found] ` <20140822150508.GA1321-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2014-08-22 15:26 ` Alan Stern
2014-08-22 15:08 ` Martin K. Petersen
2014-08-22 15:39 ` James Bottomley
2014-08-22 17:29 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1408221249360.967-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2014-08-24 15:04 ` Christoph Hellwig
2014-08-25 14:44 ` Alan Stern
2014-08-25 19:39 ` James Bottomley
[not found] ` <1408995547.3629.7.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
2014-08-25 20:12 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1408251545580.1385-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2014-08-25 21:19 ` Alan Stern
2014-08-25 21:30 ` James Bottomley
2014-08-06 13:37 ` bugzilla-daemon
2014-08-06 20:09 ` bugzilla-daemon
2014-08-06 20:25 ` bugzilla-daemon
2014-08-06 21:16 ` bugzilla-daemon
2014-08-07 15:58 ` bugzilla-daemon
2014-08-07 16:10 ` bugzilla-daemon
2014-08-20 19:15 ` bugzilla-daemon
2014-08-21 14:41 ` bugzilla-daemon
2014-08-21 17:31 ` bugzilla-daemon
2014-08-21 21:43 ` bugzilla-daemon
2014-08-22 14:53 ` bugzilla-daemon
2014-08-22 15:08 ` bugzilla-daemon
2014-08-22 15:26 ` bugzilla-daemon
2014-08-22 17:29 ` bugzilla-daemon
2014-08-25 14:44 ` bugzilla-daemon
2014-08-25 20:12 ` bugzilla-daemon
2014-08-25 21:19 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140821215744.GA29651@infradead.org \
--to=hch@infradead.org \
--cc=bugzilla-daemon@bugzilla.kernel.org \
--cc=dgilbert@interlog.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stern@rowland.harvard.edu \
--cc=tiziano.bacocco@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.