All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Possible bug in U-Boot Exynos clock driver
Date: Fri, 22 Aug 2014 08:38:59 +0200	[thread overview]
Message-ID: <20140822063858.GA4956@ulmo> (raw)

Hi,

I've been running a couple of builds for a patch that I'm working on and
I noticed the following errors happening for all Exynos boards:

	arch/arm/cpu/armv7/exynos/clock.c: In function 'clock_get_periph_rate':
	arch/arm/cpu/armv7/exynos/clock.c:263:47: warning: array subscript is above array bounds [-Warray-bounds]
	  struct clk_bit_info *bit_info = &clk_bit_info[peripheral];
                                               ^
The problem seems to be that clock_get_periph_rate() is called with the
PERIPH_ID_PWM0 parameter in get_pwm_clk(). clock_get_periph_rate() in
turn calls exynos5_get_periph_rate() which uses the peripheral parameter
to index into the clk_bit_info array. However, PERIPH_ID_PWM0 seems to
evaluate to 132, but the clk_bit_info contains only 29 elements.

I don't know how to properly fix this, but perhaps the clk_bit_info
table needs to be extended to cover other clocks?

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140822/10db3df5/attachment.pgp>

                 reply	other threads:[~2014-08-22  6:38 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140822063858.GA4956@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.