From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=++koElXUQ/EnJ4+fSnnIw/vQ6n+cVpaaBQ8odJOHaic=; b=gKJtJrbudVZ4HHvsWmRriGk3pO8Nvms5BH2Xjm4AEN6hCz0OcjG9qvZMHAQmUoPklw 73MfMQ+N7t9QqztjsZJlj5a8fPVh7O6ZHYTVqNvplcS8tEXZwhMe9h9dy05aUND0l534 8/DhowbPMBzLP+459eUEbnaq+eBeXAGgzazQY2t5sRK0w811TIpA98HIlj1sZw2eH5qS 73q4EPsS2zOSmOYGsucYSwhugu3unA+rVcKuwjvVQUnsk5ZqCC2STaZmC6qyW2Ar7Op2 JvXYs7NMyzuw5F5kpP7sHWBvXuBJczai+ppJYUGCWi+FwnmHthKWoxJLpiwwPHraAb/S Meyw== From: Andreea-Cristina Bernat Message-ID: <20140822130609.GA19576@ada> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [Bridge] [PATCH] br_multicast: Replace rcu_assign_pointer() with RCU_INIT_POINTER() List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Fri, 22 Aug 2014 13:06:19 -0000 To: stephen@networkplumber.org, davem@davemloft.net, bridge@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: paulmck@linux.vnet.ibm.com The use of "rcu_assign_pointer()" is NULLing out the pointer. According to RCU_INIT_POINTER()'s block comment: "1. This use of RCU_INIT_POINTER() is NULLing out the pointer" it is better to use it instead of rcu_assign_pointer() because it has a smaller overhead. The following Coccinelle semantic patch was used: @@ @@ - rcu_assign_pointer + RCU_INIT_POINTER (..., NULL) Signed-off-by: Andreea-Cristina Bernat --- net/bridge/br_multicast.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c index abfa0b65..9b64383 100644 --- a/net/bridge/br_multicast.c +++ b/net/bridge/br_multicast.c @@ -1822,7 +1822,7 @@ static void br_multicast_query_expired(struct net_bridge *br, if (query->startup_sent < br->multicast_startup_query_count) query->startup_sent++; - rcu_assign_pointer(querier, NULL); + RCU_INIT_POINTER(querier, NULL); br_multicast_send_query(br, NULL, query); spin_unlock(&br->multicast_lock); } -- 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756412AbaHVNGV (ORCPT ); Fri, 22 Aug 2014 09:06:21 -0400 Received: from mail-we0-f177.google.com ([74.125.82.177]:39396 "EHLO mail-we0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756195AbaHVNGS (ORCPT ); Fri, 22 Aug 2014 09:06:18 -0400 Date: Fri, 22 Aug 2014 16:06:09 +0300 From: Andreea-Cristina Bernat To: stephen@networkplumber.org, davem@davemloft.net, bridge@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: paulmck@linux.vnet.ibm.com Subject: [PATCH] br_multicast: Replace rcu_assign_pointer() with RCU_INIT_POINTER() Message-ID: <20140822130609.GA19576@ada> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The use of "rcu_assign_pointer()" is NULLing out the pointer. According to RCU_INIT_POINTER()'s block comment: "1. This use of RCU_INIT_POINTER() is NULLing out the pointer" it is better to use it instead of rcu_assign_pointer() because it has a smaller overhead. The following Coccinelle semantic patch was used: @@ @@ - rcu_assign_pointer + RCU_INIT_POINTER (..., NULL) Signed-off-by: Andreea-Cristina Bernat --- net/bridge/br_multicast.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c index abfa0b65..9b64383 100644 --- a/net/bridge/br_multicast.c +++ b/net/bridge/br_multicast.c @@ -1822,7 +1822,7 @@ static void br_multicast_query_expired(struct net_bridge *br, if (query->startup_sent < br->multicast_startup_query_count) query->startup_sent++; - rcu_assign_pointer(querier, NULL); + RCU_INIT_POINTER(querier, NULL); br_multicast_send_query(br, NULL, query); spin_unlock(&br->multicast_lock); } -- 1.9.1