From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
David Ahern <dsahern@gmail.com>, Andi Kleen <andi@firstfloor.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH v2 2/2] perf hists browser: Consolidate callchain print functions in TUI
Date: Fri, 22 Aug 2014 11:47:55 -0300 [thread overview]
Message-ID: <20140822144755.GA3473@kernel.org> (raw)
In-Reply-To: <20140822080236.GB7714@gmail.com>
Em Fri, Aug 22, 2014 at 10:02:36AM +0200, Ingo Molnar escreveu:
> > > +struct callchain_print_arg {
> > > + /* for hists browser */
> > > + unsigned short row;
> > > + off_t row_offset;
> > > + bool is_current_entry;
> > > +
> > > + /* for file dump */
> > > + FILE *fp;
> > > + int printed;
> > > +};
>
> Just a data type definition nitpicking pet peeve of mine, don't
> you guys too find this vertically aligned form infinitely more
> readable:
>
> struct callchain_print_arg {
> /* for hists browser */
> unsigned short row;
> off_t row_offset;
> bool is_current_entry;
>
> /* for file dump */
> FILE *fp;
> int printed;
> };
>
> especially when looking at it via email, without syntax
> highlighting?
Agreed, will make it so when applying it.
- Arnaldo
next prev parent reply other threads:[~2014-08-22 14:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 1:15 [PATCHSET 0/2] perf hists browser: Cleanup callchain routines (v2) Namhyung Kim
2014-08-21 1:15 ` [PATCH v2 1/2] perf hists browser: Cleanup callchain print functions Namhyung Kim
2014-08-24 14:58 ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-08-21 1:15 ` [PATCH v2 2/2] perf hists browser: Consolidate callchain print functions in TUI Namhyung Kim
2014-08-21 15:43 ` Arnaldo Carvalho de Melo
2014-08-22 8:02 ` Ingo Molnar
2014-08-22 14:47 ` Arnaldo Carvalho de Melo [this message]
2014-08-21 8:11 ` [PATCHSET 0/2] perf hists browser: Cleanup callchain routines (v2) Jiri Olsa
2014-08-21 15:25 ` Arnaldo Carvalho de Melo
2014-08-22 8:03 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140822144755.GA3473@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.