diff for duplicates of <20140822163918.GG10066@atomide.com> diff --git a/a/1.txt b/N1/1.txt index 67e6f13..4fe808d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,9 +1,9 @@ Hi, -* Grazvydas Ignotas <notasas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> [140822 06:21]: +* Grazvydas Ignotas <notasas@gmail.com> [140822 06:21]: > Hi, > -> On Thu, Aug 21, 2014 at 7:48 PM, Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> wrote: +> On Thu, Aug 21, 2014 at 7:48 PM, Tony Lindgren <tony@atomide.com> wrote: > > Commit 249751f22380 ("usb: phy: twl4030-usb: poll for ID disconnect") > > added twl4030_id_workaround_work() to deal with lost interrupts > > after ID pin goes down. However, this currently only works for the @@ -58,7 +58,7 @@ Regards, Tony 8< --------------------- -From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> +From: Tony Lindgren <tony@atomide.com> Date: Thu, 21 Aug 2014 08:59:43 -0700 Subject: [PATCH] usb: phy: twl4030-usb: Fix lost interrupts after ID pin goes down @@ -83,12 +83,12 @@ already do pretty much the same thing, let's call twl4030_usb_irq() from twl4030_id_workaround_work() instead of adding some more duplicate code. We also must call sysfs_notify() only when we have an interrupt and not from the delayed work as notified by -Grazvydas Ignotas <notasas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>. +Grazvydas Ignotas <notasas@gmail.com>. Fixes: f1ddc24c9e33 ("usb: phy: twl4030-usb: remove *set_suspend* and *phy_init* ops") -Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org # v3.13+ -Acked-by: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org> -Signed-off-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> +Cc: stable@vger.kernel.org # v3.13+ +Acked-by: Felipe Balbi <balbi@ti.com> +Signed-off-by: Tony Lindgren <tony@atomide.com> --- a/drivers/phy/phy-twl4030-usb.c +++ b/drivers/phy/phy-twl4030-usb.c @@ -124,3 +124,19 @@ Signed-off-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> - status_changed = true; - } - spin_unlock_irq(&twl->lock); +- +- if (status_changed) { +- dev_dbg(twl->dev, "handle missing status change to %d\n", +- status); +- omap_musb_mailbox(status); +- } + +- /* don't schedule during sleep - irq works right then */ +- if (status == OMAP_MUSB_ID_GROUND && !twl->asleep) { +- cancel_delayed_work(&twl->id_workaround_work); +- schedule_delayed_work(&twl->id_workaround_work, HZ); +- } ++ twl4030_usb_irq(0, twl); + } + + static int twl4030_phy_init(struct phy *phy) diff --git a/a/content_digest b/N1/content_digest index 8b06669..3e2fa68 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,23 +1,22 @@ "ref\020140821164803.GB10066@atomide.com\0" "ref\0CANOLnOM_5VXDAstbQN45wRyYq9k26PWM0z9uZ+C2VmhOqzCuEw@mail.gmail.com\0" - "ref\0CANOLnOM_5VXDAstbQN45wRyYq9k26PWM0z9uZ+C2VmhOqzCuEw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org\0" - "From\0Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>\0" + "From\0Tony Lindgren <tony@atomide.com>\0" "Subject\0Re: [PATCH] usb: phy: twl4030-usb: Fix lost interrupts after ID pin goes down\0" "Date\0Fri, 22 Aug 2014 09:39:18 -0700\0" - "To\0Grazvydas Ignotas <notasas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\0" - "Cc\0Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>" - Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org> - linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> - Linux USB Mailing List <linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> - " linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>\0" + "To\0Grazvydas Ignotas <notasas@gmail.com>\0" + "Cc\0Kishon Vijay Abraham I <kishon@ti.com>" + Felipe Balbi <balbi@ti.com> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + Linux USB Mailing List <linux-usb@vger.kernel.org> + " linux-omap@vger.kernel.org <linux-omap@vger.kernel.org>\0" "\00:1\0" "b\0" "Hi,\n" "\n" - "* Grazvydas Ignotas <notasas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> [140822 06:21]:\n" + "* Grazvydas Ignotas <notasas@gmail.com> [140822 06:21]:\n" "> Hi,\n" "> \n" - "> On Thu, Aug 21, 2014 at 7:48 PM, Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> wrote:\n" + "> On Thu, Aug 21, 2014 at 7:48 PM, Tony Lindgren <tony@atomide.com> wrote:\n" "> > Commit 249751f22380 (\"usb: phy: twl4030-usb: poll for ID disconnect\")\n" "> > added twl4030_id_workaround_work() to deal with lost interrupts\n" "> > after ID pin goes down. However, this currently only works for the\n" @@ -72,7 +71,7 @@ "Tony\n" "\n" "8< ---------------------\n" - "From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>\n" + "From: Tony Lindgren <tony@atomide.com>\n" "Date: Thu, 21 Aug 2014 08:59:43 -0700\n" "Subject: [PATCH] usb: phy: twl4030-usb: Fix lost interrupts after ID pin goes down\n" "\n" @@ -97,12 +96,12 @@ "from twl4030_id_workaround_work() instead of adding some more\n" "duplicate code. We also must call sysfs_notify() only when we have\n" "an interrupt and not from the delayed work as notified by\n" - "Grazvydas Ignotas <notasas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>.\n" + "Grazvydas Ignotas <notasas@gmail.com>.\n" "\n" "Fixes: f1ddc24c9e33 (\"usb: phy: twl4030-usb: remove *set_suspend* and *phy_init* ops\")\n" - "Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org # v3.13+\n" - "Acked-by: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>\n" - "Signed-off-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>\n" + "Cc: stable@vger.kernel.org # v3.13+\n" + "Acked-by: Felipe Balbi <balbi@ti.com>\n" + "Signed-off-by: Tony Lindgren <tony@atomide.com>\n" "\n" "--- a/drivers/phy/phy-twl4030-usb.c\n" "+++ b/drivers/phy/phy-twl4030-usb.c\n" @@ -137,6 +136,22 @@ "-\t\ttwl->linkstat = status;\n" "-\t\tstatus_changed = true;\n" "-\t}\n" - "-\tspin_unlock_irq(&twl->lock);" + "-\tspin_unlock_irq(&twl->lock);\n" + "-\n" + "-\tif (status_changed) {\n" + "-\t\tdev_dbg(twl->dev, \"handle missing status change to %d\\n\",\n" + "-\t\t\t\tstatus);\n" + "-\t\tomap_musb_mailbox(status);\n" + "-\t}\n" + " \n" + "-\t/* don't schedule during sleep - irq works right then */\n" + "-\tif (status == OMAP_MUSB_ID_GROUND && !twl->asleep) {\n" + "-\t\tcancel_delayed_work(&twl->id_workaround_work);\n" + "-\t\tschedule_delayed_work(&twl->id_workaround_work, HZ);\n" + "-\t}\n" + "+\ttwl4030_usb_irq(0, twl);\n" + " }\n" + " \n" + static int twl4030_phy_init(struct phy *phy) -f86b51d84547bf49d2dc016919e0626dd6254bf1f582ab1a00a6b3c8ba59d52d +1141d5b9437dca0446ee7721f3611307e67fca2fc49987883b7d22580317402a
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.