From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bryan Wu <cooloney@gmail.com>
Cc: Michal Sojka <sojka@merica.cz>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
michal.vokac@comap.cz, Richard Purdie <rpurdie@rpsys.net>,
Felipe Balbi <balbi@ti.com>, lkml <linux-kernel@vger.kernel.org>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/2] leds: usb: Add LED trigger for USB gadget activity
Date: Fri, 22 Aug 2014 16:42:44 -0500 [thread overview]
Message-ID: <20140822214244.GA25922@kroah.com> (raw)
In-Reply-To: <CAK5ve-LaGPgsAVMMMw3=EWpjom5NF29btu0Yxjg=6iwPpioQFg@mail.gmail.com>
On Fri, Aug 22, 2014 at 10:39:03AM -0700, Bryan Wu wrote:
> On Fri, Aug 22, 2014 at 4:53 AM, Michal Sojka <sojka@merica.cz> wrote:
> > With this patch, USB gadget activity can be signaled by blinking a LED.
> >
> > Since there is no generic code where to put the trigger for all USB
> > controllers, each USB controller needs to call the trigger individually.
> > This patch adds the call only for the musb controller where I can test
> > it.
> >
>
> Generally I think one led trigger for both USB host and USB gadget
> activity is good enough. We don't need 2 same led trigger here.
What about systems that have both running at the same time? Don't you
want individual control?
> And probably you can just put this code in drivers/usb subsystem,
> since this driver is quite simple to add to USB subsystem.
I have no objection to that, if the LED people don't mind it.
thanks,
greg k-h
next prev parent reply other threads:[~2014-08-22 21:43 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 11:53 [PATCH 1/2] leds: usb: Add LED trigger for USB gadget activity Michal Sojka
2014-08-22 11:53 ` [PATCH 2/2] leds: usb: Add LED trigger for USB host activity Michal Sojka
[not found] ` <1408708399-20423-1-git-send-email-sojka-Knnw/vAvyUalVyrhU4qvOw@public.gmane.org>
2014-08-22 17:39 ` [PATCH 1/2] leds: usb: Add LED trigger for USB gadget activity Bryan Wu
2014-08-22 17:39 ` Bryan Wu
2014-08-22 21:42 ` Greg Kroah-Hartman [this message]
2014-08-22 23:41 ` Bryan Wu
2014-08-22 23:44 ` Michal Sojka
2014-08-22 21:59 ` Felipe Balbi
2014-08-22 21:59 ` Felipe Balbi
2014-08-22 23:54 ` Michal Sojka
2014-08-22 23:54 ` Michal Sojka
2014-08-23 0:08 ` [PATCH v2 0/3] LED triggers for USB host and device Michal Sojka
2014-08-23 0:08 ` [PATCH v2 1/3] usb: Add missing #include Michal Sojka
2014-08-23 0:08 ` [PATCH v2 2/3] usb: Add LED trigger for USB host activity Michal Sojka
2014-08-23 0:30 ` Bryan Wu
2014-08-23 9:52 ` Michal Sojka
[not found] ` <87egw7a5yd.fsf-RBRde3N6TzKEyWgh05NgWw@public.gmane.org>
2014-08-25 18:59 ` Bryan Wu
2014-08-25 18:59 ` Bryan Wu
2014-08-27 13:03 ` [PATCH v3 0/2] LED triggers for USB host and device Michal Sojka
2014-08-27 13:03 ` [PATCH v3 1/2] usb: gadget: Refactor request completion Michal Sojka
2014-08-27 13:43 ` Michal Sojka
2014-08-27 15:03 ` Alan Stern
2014-08-27 15:03 ` Alan Stern
[not found] ` <1409144625-25274-2-git-send-email-sojka-Knnw/vAvyUalVyrhU4qvOw@public.gmane.org>
2014-08-27 20:17 ` Felipe Balbi
2014-08-27 20:17 ` Felipe Balbi
2014-08-27 13:03 ` [PATCH v3 2/2] usb: Add LED triggers for USB activity Michal Sojka
2014-08-27 19:27 ` Greg Kroah-Hartman
2014-08-27 19:30 ` Felipe Balbi
2014-08-27 19:30 ` Felipe Balbi
2014-08-27 20:57 ` [PATCH v4 0/3] LED triggers for USB host and device Michal Sojka
2014-08-27 20:57 ` [PATCH v4 1/3] usb: gadget: Refactor request completion Michal Sojka
2014-08-27 21:03 ` Alan Stern
2014-08-27 21:03 ` Alan Stern
2014-08-27 21:09 ` Greg Kroah-Hartman
2014-08-27 20:57 ` [PATCH v4 2/3] usb: Rename usb-common.c Michal Sojka
2014-08-27 20:58 ` [PATCH v4 3/3] usb: Add LED triggers for USB activity Michal Sojka
2014-08-27 21:08 ` Greg Kroah-Hartman
2014-08-29 12:57 ` Michal Sojka
2014-08-29 13:07 ` [PATCH v5 0/3] LED triggers for USB host and device Michal Sojka
2014-08-29 13:07 ` [PATCH v5 1/3] usb: gadget: Refactor request completion Michal Sojka
2014-08-29 13:07 ` [PATCH v5 2/3] usb: Rename usb-common.c Michal Sojka
2014-08-29 13:07 ` [PATCH v5 3/3] usb: Add LED triggers for USB activity Michal Sojka
2014-08-23 0:08 ` [PATCH v2 3/3] usb: Add LED trigger for USB gadget activity Michal Sojka
2014-08-23 0:23 ` [PATCH v2 0/3] LED triggers for USB host and device Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140822214244.GA25922@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@ti.com \
--cc=cooloney@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michal.vokac@comap.cz \
--cc=rpurdie@rpsys.net \
--cc=sojka@merica.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.