From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jlayton@primarydata.com>
Cc: linux-fsdevel@vger.kernel.org, bfields@fieldses.org
Subject: Re: [PATCH] locks: pass correct "before" pointer to locks_unlink_lock in generic_add_lease
Date: Sat, 23 Aug 2014 04:48:18 -0700 [thread overview]
Message-ID: <20140823114818.GA24896@infradead.org> (raw)
In-Reply-To: <1408790179-7809-1-git-send-email-jlayton@primarydata.com>
On Sat, Aug 23, 2014 at 06:36:19AM -0400, Jeff Layton wrote:
> The argument to locks_unlink_lock can't be just any pointer to a
> pointer. It must be a pointer to the fl_next field in the previous
> lock in the list.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
This might explain some memory corruption I saw in the lease code while
trying out a new creative (ab-)user of the lease code..
next prev parent reply other threads:[~2014-08-23 11:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-23 10:36 [PATCH] locks: pass correct "before" pointer to locks_unlink_lock in generic_add_lease Jeff Layton
2014-08-23 11:48 ` Christoph Hellwig [this message]
2014-08-23 12:09 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140823114818.GA24896@infradead.org \
--to=hch@infradead.org \
--cc=bfields@fieldses.org \
--cc=jlayton@primarydata.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.