All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Knut Omang <knut.omang@oracle.com>
Cc: Marcel Apfelbaum <marcel.a@redhat.com>,
	Alexey Kardashevskiy <aik@ozlabs.ru>,
	Juan Quintela <quintela@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	qemu-devel@nongnu.org, "Gonglei (Arei)" <arei.gonglei@huawei.com>,
	Igor Mammedov <imammedo@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 4/4] ioh3420: Enable ARI forwarding
Date: Mon, 25 Aug 2014 00:52:58 +0200	[thread overview]
Message-ID: <20140824225258.GA14580@redhat.com> (raw)
In-Reply-To: <1408887140-3320-5-git-send-email-knut.omang@oracle.com>

On Sun, Aug 24, 2014 at 03:32:20PM +0200, Knut Omang wrote:
> Signed-off-by: Knut Omang <knut.omang@oracle.com>

BTW pcie_cap_is_arifwd_enabled is still unused.
We really should use it to make ARI work properly, right?

> ---
>  hw/pci-bridge/ioh3420.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hw/pci-bridge/ioh3420.c b/hw/pci-bridge/ioh3420.c
> index e6674a1..cce2fdd 100644
> --- a/hw/pci-bridge/ioh3420.c
> +++ b/hw/pci-bridge/ioh3420.c
> @@ -85,6 +85,7 @@ static void ioh3420_reset(DeviceState *qdev)
>      pcie_cap_root_reset(d);
>      pcie_cap_deverr_reset(d);
>      pcie_cap_slot_reset(d);
> +    pcie_cap_arifwd_reset(d);
>      pcie_aer_root_reset(d);
>      pci_bridge_reset(qdev);
>      pci_bridge_disable_base_limit(d);
> @@ -119,6 +120,7 @@ static int ioh3420_initfn(PCIDevice *d)
>          goto err_msi;
>      }
>  
> +    pcie_cap_arifwd_init(d);
>      pcie_cap_deverr_init(d);
>      pcie_cap_slot_init(d, s->slot);
>      pcie_chassis_create(s->chassis);
> -- 
> 1.9.0

  reply	other threads:[~2014-08-24 22:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-24 13:32 [Qemu-devel] [PATCH v2 0/4] q35: Minor fixes/enhancements to improve usability of root ports Knut Omang
2014-08-24 13:32 ` [Qemu-devel] [PATCH v2 1/4] pcie: Fix incorrect write to the ari capability next function field Knut Omang
2014-08-24 13:32 ` [Qemu-devel] [PATCH v2 2/4] pcie: Rename the pcie_cap_ari_* functions to pcie_cap_arifwd_* Knut Omang
2014-08-24 13:32 ` [Qemu-devel] [PATCH v2 3/4] ioh3420: Remove obsoleted, unused ioh3420_init function Knut Omang
2014-08-25  7:47   ` Gonglei (Arei)
2014-08-25  9:15     ` Knut Omang
2014-08-24 13:32 ` [Qemu-devel] [PATCH v2 4/4] ioh3420: Enable ARI forwarding Knut Omang
2014-08-24 22:52   ` Michael S. Tsirkin [this message]
2014-08-25  6:09     ` Gonglei (Arei)
2014-08-25  9:13       ` Knut Omang
2014-08-25 19:57         ` Michael S. Tsirkin
2014-08-24 20:44 ` [Qemu-devel] [PATCH v2 0/4] q35: Minor fixes/enhancements to improve usability of root ports Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140824225258.GA14580@redhat.com \
    --to=mst@redhat.com \
    --cc=aik@ozlabs.ru \
    --cc=arei.gonglei@huawei.com \
    --cc=armbru@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=knut.omang@oracle.com \
    --cc=marcel.a@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.