All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawn.guo@freescale.com (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: imx28-evk: Fix display duplicate name warning
Date: Mon, 25 Aug 2014 10:27:52 +0800	[thread overview]
Message-ID: <20140825022751.GI2540@dragon> (raw)
In-Reply-To: <1408672772-6365-1-git-send-email-festevam@gmail.com>

On Thu, Aug 21, 2014 at 10:59:32PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Provide the display unit address in order to fix the following warning:
> 
> [    0.114765] regulator-dummy: no parameters
> [    0.152091] device-tree: Duplicate name in lcdif at 80030000, renamed to "display#1"
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  arch/arm/boot/dts/imx28-evk.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx28-evk.dts b/arch/arm/boot/dts/imx28-evk.dts
> index e4cc44c..c258b2c 100644
> --- a/arch/arm/boot/dts/imx28-evk.dts
> +++ b/arch/arm/boot/dts/imx28-evk.dts
> @@ -127,7 +127,7 @@
>  				display = <&display>;
>  				status = "okay";
>  
> -				display: display {
> +				display: display at 0 {

Unit address only makes sense where parent has #address-cells and
#size-cells and the node itself has 'reg' property.

I guess it's more appropriate to name the node in particular display
device model that the node is defining?

Shawn

>  					bits-per-pixel = <32>;
>  					bus-width = <24>;
>  
> -- 
> 1.9.1
> 

  reply	other threads:[~2014-08-25  2:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-22  1:59 [PATCH] ARM: dts: imx28-evk: Fix display duplicate name warning Fabio Estevam
2014-08-25  2:27 ` Shawn Guo [this message]
2014-08-25  2:34   ` Fabio Estevam
2014-08-25  2:44     ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140825022751.GI2540@dragon \
    --to=shawn.guo@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.