From: Ralf Baechle <ralf@linux-mips.org>
To: Jayachandran C <jchandra@broadcom.com>
Cc: linux-mips@linux-mips.org, chenhc@lemote.com,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH 1/2] MIPS: Netlogic: Use MIPS topology.h
Date: Mon, 25 Aug 2014 15:20:50 +0200 [thread overview]
Message-ID: <20140825132050.GH27724@linux-mips.org> (raw)
In-Reply-To: <1408681112-26744-1-git-send-email-jchandra@broadcom.com>
On Fri, Aug 22, 2014 at 09:48:31AM +0530, Jayachandran C wrote:
> commit bda4584cd943 ("MIPS: Support CPU topology files in sysfs")
> added topology related macros for all MIPS platforms. This causes
> compile failure for Netlogic platforms with errors like:
>
> arch/mips/include/asm/mach-netlogic/topology.h:14:0: error: "topology_physical_package_id" redefined [-Werror]
>
> Fix this by dropping Netlogic specific topology.h and setting up package
> field in cpu data.
I've already applied Guenter Roeck's patch
https://patchwork.linux-mips.org/patch/7513/ as commit
bbbf6d8768f5cac3523c408917083a111b1f3ffe [MIPS: Netlogic: Use MIPS
topology.h] and the pull request for that one is out to Linus.
So if you think your solution is nicer, please send a followup patch,
> Signed-off-by: Jayachandran C <jchandra@broadcom.com>
> ---
> [Resending this, looks like linux-mips.org is down]
Ironically the announcement of the new system also got affected by the
email woes and only went out after resending it ... By now things should
be all back to normal and I can't believe how much faster some operations
such as git push have become!
Ralf
prev parent reply other threads:[~2014-08-25 13:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 3:16 [PATCH 1/2] MIPS: Move CPU topology macros to topology.h Huacai Chen
2014-08-08 3:16 ` [PATCH 2/2] MIPS: Loongson: Fix COP2 usage for preemptible kernel Huacai Chen
2014-08-08 12:12 ` Sergei Shtylyov
2014-08-08 13:47 ` [PATCH 1/2] MIPS: Move CPU topology macros to topology.h Ralf Baechle
2014-08-13 0:18 ` Jayachandran C.
2014-08-13 0:18 ` Jayachandran C.
2014-08-20 3:57 ` Huacai Chen
2014-08-22 4:18 ` [PATCH 1/2] MIPS: Netlogic: Use MIPS topology.h Jayachandran C
2014-08-22 4:18 ` Jayachandran C
2014-08-22 4:18 ` [PATCH 2/2] MIPS: Move topology macros to topology.h Jayachandran C
2014-08-22 4:18 ` Jayachandran C
2014-08-25 13:20 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140825132050.GH27724@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=chenhc@lemote.com \
--cc=jchandra@broadcom.com \
--cc=linux-mips@linux-mips.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.