From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Enable vblank interrupts for CRC generation Date: Mon, 25 Aug 2014 16:24:56 +0300 Message-ID: <20140825132456.GC4193@intel.com> References: <1408969691-5223-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 1990B89CF2 for ; Mon, 25 Aug 2014 06:25:00 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1408969691-5223-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Aug 25, 2014 at 01:28:11PM +0100, Chris Wilson wrote: > Pineview requires this. But this changes the debug API... > = > References: https://bugs.freedesktop.org/show_bug.cgi?id=3D82280 Isn't this just the same old igt_display bug that it doesn't check that the pipe<->port combination is valid? > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/i915_debugfs.c | 7 +++++++ > 1 file changed, 7 insertions(+) > = > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i= 915_debugfs.c > index d76a298a0eb7..65024a9bc95f 100644 > --- a/drivers/gpu/drm/i915/i915_debugfs.c > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > @@ -2713,10 +2713,15 @@ static int i915_pipe_crc_open(struct inode *inode= , struct file *filep) > struct pipe_crc_info *info =3D inode->i_private; > struct drm_i915_private *dev_priv =3D info->dev->dev_private; > struct intel_pipe_crc *pipe_crc =3D &dev_priv->pipe_crc[info->pipe]; > + int ret; > = > if (info->pipe >=3D INTEL_INFO(info->dev)->num_pipes) > return -ENODEV; > = > + ret =3D drm_vblank_get(dev_priv->dev, info->pipe); > + if (ret) > + return ret; > + > spin_lock_irq(&pipe_crc->lock); > = > if (pipe_crc->opened) { > @@ -2742,6 +2747,8 @@ static int i915_pipe_crc_release(struct inode *inod= e, struct file *filep) > pipe_crc->opened =3D false; > spin_unlock_irq(&pipe_crc->lock); > = > + drm_vblank_put(dev_priv->dev, info->pipe); > + > return 0; > } > = > -- = > 2.1.0 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel OTC